From c23debb133d0aedaff1c5bab540f7137d81be67a Mon Sep 17 00:00:00 2001 From: Joe Reuter Date: Fri, 18 Mar 2022 09:18:22 +0100 Subject: [PATCH 1/2] fix functional tests (#127979) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 1c7f805509efc8c852728ab7b4ecc68e4fc1ca35) --- .../functional/apps/lens/add_to_dashboard.ts | 1 + .../functional/apps/lens/runtime_fields.ts | 20 ++++++++++--------- .../test/functional/page_objects/lens_page.ts | 4 +--- 3 files changed, 13 insertions(+), 12 deletions(-) diff --git a/x-pack/test/functional/apps/lens/add_to_dashboard.ts b/x-pack/test/functional/apps/lens/add_to_dashboard.ts index aa4651cbffe0c0..3c39cc3bd64965 100644 --- a/x-pack/test/functional/apps/lens/add_to_dashboard.ts +++ b/x-pack/test/functional/apps/lens/add_to_dashboard.ts @@ -59,6 +59,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await listingTable.searchForItemWithName('Artistpreviouslyknownaslens'); await PageObjects.lens.clickVisualizeListItemTitle('Artistpreviouslyknownaslens'); await PageObjects.lens.goToTimeRange(); + await PageObjects.lens.waitForVisualization('mtrVis'); await PageObjects.lens.assertMetric('Maximum of bytes', '19,986'); }; diff --git a/x-pack/test/functional/apps/lens/runtime_fields.ts b/x-pack/test/functional/apps/lens/runtime_fields.ts index dec66fc20caef1..1353bcaea2c848 100644 --- a/x-pack/test/functional/apps/lens/runtime_fields.ts +++ b/x-pack/test/functional/apps/lens/runtime_fields.ts @@ -20,15 +20,17 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await PageObjects.visualize.clickVisType('lens'); await PageObjects.lens.goToTimeRange(); await PageObjects.lens.switchToVisualization('lnsDatatable'); - await PageObjects.lens.clickAddField(); - await fieldEditor.setName('runtimefield'); - await fieldEditor.enableValue(); - await fieldEditor.typeScript("emit('abc')"); - await fieldEditor.save(); - await PageObjects.header.waitUntilLoadingHasFinished(); - await PageObjects.lens.searchField('runtime'); - await PageObjects.lens.waitForField('runtimefield'); - await PageObjects.lens.dragFieldToWorkspace('runtimefield'); + await retry.try(async () => { + await PageObjects.lens.clickAddField(); + await fieldEditor.setName('runtimefield'); + await fieldEditor.enableValue(); + await fieldEditor.typeScript("emit('abc')"); + await fieldEditor.save(); + await PageObjects.header.waitUntilLoadingHasFinished(); + await PageObjects.lens.searchField('runtime'); + await PageObjects.lens.waitForField('runtimefield'); + await PageObjects.lens.dragFieldToWorkspace('runtimefield'); + }); await PageObjects.lens.waitForVisualization(); expect(await PageObjects.lens.getDatatableHeaderText(0)).to.equal( 'Top values of runtimefield' diff --git a/x-pack/test/functional/page_objects/lens_page.ts b/x-pack/test/functional/page_objects/lens_page.ts index 61b0cd10750b23..bdfe9fde3b5a1b 100644 --- a/x-pack/test/functional/page_objects/lens_page.ts +++ b/x-pack/test/functional/page_objects/lens_page.ts @@ -254,9 +254,7 @@ export function LensPageProvider({ getService, getPageObjects }: FtrProviderCont }, async waitForField(field: string) { - await retry.try(async () => { - await testSubjects.existOrFail(`lnsFieldListPanelField-${field}`); - }); + await testSubjects.existOrFail(`lnsFieldListPanelField-${field}`); }, async waitForMissingDataViewWarning() { From 90b55a1d6c0e43b5579a4648cd3574ca01715e0c Mon Sep 17 00:00:00 2001 From: Joe Reuter Date: Wed, 23 Mar 2022 11:34:34 +0100 Subject: [PATCH 2/2] Update add_to_dashboard.ts --- x-pack/test/functional/apps/lens/add_to_dashboard.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/test/functional/apps/lens/add_to_dashboard.ts b/x-pack/test/functional/apps/lens/add_to_dashboard.ts index 3c39cc3bd64965..07761e1dc6ef9b 100644 --- a/x-pack/test/functional/apps/lens/add_to_dashboard.ts +++ b/x-pack/test/functional/apps/lens/add_to_dashboard.ts @@ -59,7 +59,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await listingTable.searchForItemWithName('Artistpreviouslyknownaslens'); await PageObjects.lens.clickVisualizeListItemTitle('Artistpreviouslyknownaslens'); await PageObjects.lens.goToTimeRange(); - await PageObjects.lens.waitForVisualization('mtrVis'); + await PageObjects.lens.waitForVisualization(); await PageObjects.lens.assertMetric('Maximum of bytes', '19,986'); };