[Security Solutions] Create all users tab on user page #128375

machadoum · 2022-03-23T13:57:38Z

Summary

Create 'All Users' tab on the User page. It also renames the authentication tab which was previously called 'All users'.

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)

machadoum · 2022-03-24T14:28:50Z

x-pack/plugins/security_solution/public/common/containers/use_search_strategy/index.tsx

-  skip?: boolean;
+  /**
+   * When the flag switches from `false` to `true`, it will abort any ongoing request.
+   */
+  abort?: boolean;


@stephmilovic I renamed it because it doesn't skip the request, but instead, it aborts any ongoing request.

machadoum · 2022-03-24T14:29:49Z

x-pack/plugins/security_solution/public/common/containers/use_search_strategy/index.tsx

-    if (error != null) {
+    if (error != null && !(error instanceof AbortError)) {


It avoids showing annoying popups with errors when the request is aborted.

stephmilovic

Code reviewed ✅ manual testing ✅ LGTM!

machadoum · 2022-03-28T08:54:08Z

@elasticmachine merge upstream

semd · 2022-03-28T10:35:57Z

x-pack/plugins/security_solution/public/users/components/all_users/index.tsx

+
+export const UsersTable = React.memo(UsersTableComponent);
+
+const getUsersColumns = (): UsersTableColumns => [


shouldn't we place this const before the component definition, with the rowItems?

kibana-ci · 2022-03-28T10:41:47Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`securitySolution`	2986	2991	+5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	4.8MB	4.8MB	+4.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`securitySolution`	247.3KB	247.4KB	+141.0B

History

💔 Build #33559 failed ec4c92f
💔 Build #33502 failed 847ae05
💔 Build #33444 failed 9eaddb9
💔 Build #33035 failed b29a5c6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

kibanamachine · 2022-03-28T10:42:05Z

⚪ Backport skipped

The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.

Manual backport

To create the backport manually run:

node scripts/backport --pr 128375

Questions ?

Please refer to the Backport tool documentation

semd · 2022-03-28T10:42:16Z

...y_solution/server/search_strategy/security_solution/factory/users/all/query.all_users.dsl.ts

+    },
+  ];
+
+  const agg = { user_count: { cardinality: { field: 'user.name' } } };


why is this aggregation stored in a const, but the other user_data agg is hardcoded?

semd

added a couple of minor comments. tested locally and everything working as expected, data is displayed properly, useSearchStrategy with abort and query toggle is working well, and the code looks solid. LGTM! ✅

elastic#128375

* Update user page deep links * Fix a couple of code style issues introduced on #128375 #128375

kibanamachine · 2022-03-30T10:46:19Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 128375 or prevent reminders by adding the backport:skip label.

machadoum changed the title ~~Siem explore issue 128156~~ [Security Solutions] Create all users tab on user page Mar 23, 2022

machadoum force-pushed the siem-explore-issue-128156 branch from b29a5c6 to 9eaddb9 Compare March 24, 2022 12:13

Create all users tab on user page

847ae05

machadoum force-pushed the siem-explore-issue-128156 branch from 9eaddb9 to 847ae05 Compare March 24, 2022 14:07

machadoum self-assigned this Mar 24, 2022

machadoum added v8.2.0 Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Explore release_note:enhancement enhancement New value added to drive a business result auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 24, 2022

machadoum marked this pull request as ready for review March 24, 2022 14:24

machadoum requested a review from a team as a code owner March 24, 2022 14:24

machadoum commented Mar 24, 2022

View reviewed changes

YulNaumenko self-requested a review March 24, 2022 15:09

Fix unrelated bug on user details flyout

9611287

stephmilovic approved these changes Mar 24, 2022

View reviewed changes

Fix unit test

50470bd

machadoum force-pushed the siem-explore-issue-128156 branch from ec4c92f to 50470bd Compare March 28, 2022 08:06

machadoum mentioned this pull request Mar 28, 2022

[Security Solution] Count is different in user card and user table under users page. #128577

Closed

Merge branch 'main' into siem-explore-issue-128156

075eb9a

machadoum enabled auto-merge (squash) March 28, 2022 09:09

semd self-requested a review March 28, 2022 10:14

semd reviewed Mar 28, 2022

View reviewed changes

machadoum merged commit c1b7448 into elastic:main Mar 28, 2022

semd reviewed Mar 28, 2022

View reviewed changes

semd approved these changes Mar 28, 2022

View reviewed changes

machadoum added a commit to machadoum/kibana that referenced this pull request Mar 29, 2022

Fix a couple of code style issues introduced on elastic#128375

b315812

elastic#128375

machadoum mentioned this pull request Mar 29, 2022

[Security Solution] Update user page deep links #128722

Merged

1 task

machadoum added a commit that referenced this pull request Mar 29, 2022

[Security Solution] Update user page deep links (#128722)

53dde5f

* Update user page deep links * Fix a couple of code style issues introduced on #128375 #128375

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 30, 2022

spalger added the backport:skip This commit does not require backporting label Mar 30, 2022

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solutions] Create all users tab on user page #128375

[Security Solutions] Create all users tab on user page #128375

machadoum commented Mar 23, 2022 •

edited

Loading

machadoum Mar 24, 2022

machadoum Mar 24, 2022 •

edited

Loading

stephmilovic left a comment

machadoum commented Mar 28, 2022

semd Mar 28, 2022

kibana-ci commented Mar 28, 2022

kibanamachine commented Mar 28, 2022

semd Mar 28, 2022

semd left a comment

kibanamachine commented Mar 30, 2022

		if (error != null) {
		if (error != null && !(error instanceof AbortError)) {


		export const UsersTable = React.memo(UsersTableComponent);

		const getUsersColumns = (): UsersTableColumns => [

[Security Solutions] Create all users tab on user page #128375

[Security Solutions] Create all users tab on user page #128375

Conversation

machadoum commented Mar 23, 2022 • edited Loading

Summary

Checklist

machadoum Mar 24, 2022

Choose a reason for hiding this comment

machadoum Mar 24, 2022 • edited Loading

Choose a reason for hiding this comment

stephmilovic left a comment

Choose a reason for hiding this comment

machadoum commented Mar 28, 2022

semd Mar 28, 2022

Choose a reason for hiding this comment

kibana-ci commented Mar 28, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

kibanamachine commented Mar 28, 2022

⚪ Backport skipped

Manual backport

Questions ?

semd Mar 28, 2022

Choose a reason for hiding this comment

semd left a comment

Choose a reason for hiding this comment

kibanamachine commented Mar 30, 2022

machadoum commented Mar 23, 2022 •

edited

Loading

machadoum Mar 24, 2022 •

edited

Loading