[Shared UX] Adopt multi-package strategy - ExitFullScreenButton#130355
[Shared UX] Adopt multi-package strategy - ExitFullScreenButton#130355clintandrewhall merged 7 commits intoelastic:mainfrom
Conversation
d1df360 to
b0b0958
Compare
spalger
left a comment
There was a problem hiding this comment.
LGTM! Thank you for working with us on this
|
#130390 will fix the TypeScript error you're seeing. |
|
@clintandrewhall #130403 will fix the jest config check error |
💚 Build SucceededMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
async chunk count
miscellaneous assets size
History
To update your PR or re-run it, just comment with: |
nreese
left a comment
There was a problem hiding this comment.
maps changes LGTM
code review
…tic#130355) * [Shared UX] Adopt multi-package strategy - ExitFullScreenButton * Fixing checks errors * Fix i18n * Remove SharedUX deps from Maps Co-authored-by: Spencer <spencer@elastic.co>
Summary
As we've begun adding components, we've run into a few issues with our package-based architecture, particularly with bundle size and build times. To reduce/remove the "dependency bottleneck", Shared UX is going to take a step further and adopt a "package-per-concern" approach. This means each component or "subject" of components will be packaged separately.
This PR is a sanity-checked first attempt at what these separate packages will look like.
What this PR does
ExitFullScreenButtonthat demonstrates how this divided approach will work.ExitFullScreenButtonfrom our abstracted services architecture.What this PR does not do, (that future PRs will do)
Providersinto a singleProviderinstance