New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update spy table headers when columns update #13130

Merged
merged 4 commits into from Jul 31, 2017

Conversation

Projects
None yet
4 participants
@nreese
Contributor

nreese commented Jul 26, 2017

fixes #7211

backported to 6.x: #13224
backported to 6.0: #13225

Release Note:
Ensure spy panel table headers update when new aggregation data is fetched

@Stacey-Gammon

This comment has been minimized.

Show comment
Hide comment
@Stacey-Gammon

Stacey-Gammon Jul 26, 2017

Contributor

hmmm, might be a flaky test:

08:24:50.596          │ debg  TestSubjects.find(globalLoadingIndicator)
08:24:50.597          │ debg  in displayedByCssSelector: [data-test-subj~="globalLoadingIndicator"]
08:24:53.022          │ debg  Taking screenshot "/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-selenium/test/functional/screenshots/failure/visualize app tile map visualize app tile map chart Fit data bounds should zoom to level 3.png"
08:24:53.195        └- ✖ fail: "visualize app tile map visualize app tile map chart Fit data bounds should zoom to level 3"

Not sure why the values differ, rather than a stale element error, in this failure though. lets see if it passes the second time.

jenkins, test this

Contributor

Stacey-Gammon commented Jul 26, 2017

hmmm, might be a flaky test:

08:24:50.596          │ debg  TestSubjects.find(globalLoadingIndicator)
08:24:50.597          │ debg  in displayedByCssSelector: [data-test-subj~="globalLoadingIndicator"]
08:24:53.022          │ debg  Taking screenshot "/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-selenium/test/functional/screenshots/failure/visualize app tile map visualize app tile map chart Fit data bounds should zoom to level 3.png"
08:24:53.195        └- ✖ fail: "visualize app tile map visualize app tile map chart Fit data bounds should zoom to level 3"

Not sure why the values differ, rather than a stale element error, in this failure though. lets see if it passes the second time.

jenkins, test this

@nreese

This comment has been minimized.

Show comment
Hide comment
@nreese

nreese Jul 26, 2017

Contributor

Passed a second time. Lets see what happens on another round
jenkins, test this

Contributor

nreese commented Jul 26, 2017

Passed a second time. Lets see what happens on another round
jenkins, test this

@Stacey-Gammon

This comment has been minimized.

Show comment
Hide comment
@Stacey-Gammon

Stacey-Gammon Jul 26, 2017

Contributor

Must be a flaky test, I just had the same failure in #13034. Will see what I can do.

Contributor

Stacey-Gammon commented Jul 26, 2017

Must be a flaky test, I just had the same failure in #13034. Will see what I can do.

@Stacey-Gammon

lgtm!

@thomasneirynck

yup!

@thomasneirynck

This comment has been minimized.

Show comment
Hide comment
@thomasneirynck

thomasneirynck Jul 27, 2017

Contributor

merge conflict was pretty easy, some methods got interleaved.

Contributor

thomasneirynck commented Jul 27, 2017

merge conflict was pretty easy, some methods got interleaved.

@nreese

This comment has been minimized.

Show comment
Hide comment
@nreese

nreese Jul 31, 2017

Contributor

jenkins, test this

Contributor

nreese commented Jul 31, 2017

jenkins, test this

@nreese nreese merged commit abcc055 into elastic:master Jul 31, 2017

2 checks passed

CLA Commit author has signed the CLA
Details
kibana-ci Build finished.
Details

nreese added a commit to nreese/kibana that referenced this pull request Jul 31, 2017

update spy table headers when columns update (elastic#13130)
* update paginated table headers with columns update

* remove unneeded sleep

* update getDataTableHeaders to preffered format

* use data-test-subj attribute for functional tests instead of CSS selectors

@nreese nreese added v7.0.0 and removed v6.0.0 labels Jul 31, 2017

nreese added a commit to nreese/kibana that referenced this pull request Jul 31, 2017

update spy table headers when columns update (elastic#13130)
* update paginated table headers with columns update

* remove unneeded sleep

* update getDataTableHeaders to preffered format

* use data-test-subj attribute for functional tests instead of CSS selectors

nreese added a commit that referenced this pull request Aug 2, 2017

update spy table headers when columns update (#13130) (#13224)
* update paginated table headers with columns update

* remove unneeded sleep

* update getDataTableHeaders to preffered format

* use data-test-subj attribute for functional tests instead of CSS selectors

nreese added a commit that referenced this pull request Aug 2, 2017

update spy table headers when columns update (#13130) (#13225)
* update paginated table headers with columns update

* remove unneeded sleep

* update getDataTableHeaders to preffered format

* use data-test-subj attribute for functional tests instead of CSS selectors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment