New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in percentage mode tooltip should also show percentages #13217

Merged
merged 1 commit into from Aug 1, 2017

Conversation

Projects
None yet
2 participants
@ppisljar
Member

ppisljar commented Jul 31, 2017

Release Note: Tooltips now correctly display the percentage-value in area charts where the Y-Axis is formatted in percentage mode.


Closes #12391

variation of #13212

#13212 tries to change the default label of aggregation when in percentage mode, which is actually not mentioned in #12391

this PR just fixes the bug with percentage mode (which was introduced by vislib refactor almost a year ago), so the old behavior is restored: when in percentage mode the tooltip should show both, the metric value and the percentage.

@thomasneirynck

This comment has been minimized.

Show comment
Hide comment
@thomasneirynck

thomasneirynck Jul 31, 2017

Contributor

jenkins, test this

Contributor

thomasneirynck commented Jul 31, 2017

jenkins, test this

@thomasneirynck

This comment has been minimized.

Show comment
Hide comment
@thomasneirynck

thomasneirynck Jul 31, 2017

Contributor

jenkins, test this.

Contributor

thomasneirynck commented Jul 31, 2017

jenkins, test this.

@thomasneirynck

This comment has been minimized.

Show comment
Hide comment
@thomasneirynck

thomasneirynck Jul 31, 2017

Contributor

jenkins, test this

Contributor

thomasneirynck commented Jul 31, 2017

jenkins, test this

@thomasneirynck

Okay, this makes sense. We won't do the labeling of the Y-axis for now (to show Percentage of ....).

Like how you grab the axis-config directly.

@thomasneirynck

This comment has been minimized.

Show comment
Hide comment
@thomasneirynck

thomasneirynck Jul 31, 2017

Contributor

Feel free to merge and backport to 6.x/6.0/5.x/5.5.

Thx!

Contributor

thomasneirynck commented Jul 31, 2017

Feel free to merge and backport to 6.x/6.0/5.x/5.5.

Thx!

@ppisljar ppisljar merged commit 5703ffc into elastic:master Aug 1, 2017

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
kibana-ci Build finished.
Details

ppisljar added a commit to ppisljar/kibana that referenced this pull request Aug 1, 2017

ppisljar added a commit to ppisljar/kibana that referenced this pull request Aug 1, 2017

ppisljar added a commit to ppisljar/kibana that referenced this pull request Aug 1, 2017

ppisljar added a commit to ppisljar/kibana that referenced this pull request Aug 1, 2017

ppisljar added a commit to ppisljar/kibana that referenced this pull request Aug 1, 2017

thomasneirynck added a commit that referenced this pull request Aug 1, 2017

ensure we are working with data-series (#13266)
This fixes a regression introduced by #13217.

thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Aug 1, 2017

thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Aug 1, 2017

thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Aug 1, 2017

thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Aug 1, 2017

thomasneirynck added a commit that referenced this pull request Aug 1, 2017

thomasneirynck added a commit that referenced this pull request Aug 1, 2017

thomasneirynck added a commit that referenced this pull request Aug 1, 2017

thomasneirynck added a commit that referenced this pull request Aug 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment