New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ui-select for agg selector #13292

Merged
merged 10 commits into from Aug 3, 2017

Conversation

Projects
None yet
3 participants
@lukasolson
Member

lukasolson commented Aug 2, 2017

Fixes #11586

trevan and others added some commits Jul 19, 2017

Merge branch 'use-ui-select-in-agg-selector' of git://github.com/trev…
…an/kibana into trevan-use-ui-select-in-agg-selector

lukasolson added some commits Aug 2, 2017

@lukasolson lukasolson self-assigned this Aug 2, 2017

lukasolson added some commits Aug 2, 2017

@lukasolson

This comment has been minimized.

Show comment
Hide comment
@lukasolson

lukasolson Aug 3, 2017

Member

Whew, finally! @thomasneirynck could you take one more look?

Member

lukasolson commented Aug 3, 2017

Whew, finally! @thomasneirynck could you take one more look?

@thomasneirynck

punch it Chewy!

@lukasolson lukasolson merged commit 14c9b7e into elastic:master Aug 3, 2017

2 checks passed

CLA Commit author has signed the CLA
Details
kibana-ci Build finished.
Details

lukasolson added a commit to lukasolson/kibana that referenced this pull request Aug 3, 2017

Use ui-select for agg selector (elastic#13292)
* Use ui-select for agg selector

* Fix functional tests

* Fix functional tests

* Fix test

* Fix visualize page object

* Use sortPrefixFirst in agg selector

* Fix unit tests

* Fix unit test

* Use not(.ng-hide) rather than last-child

lukasolson added a commit to lukasolson/kibana that referenced this pull request Aug 3, 2017

Use ui-select for agg selector (elastic#13292)
* Use ui-select for agg selector

* Fix functional tests

* Fix functional tests

* Fix test

* Fix visualize page object

* Use sortPrefixFirst in agg selector

* Fix unit tests

* Fix unit test

* Use not(.ng-hide) rather than last-child
@lukasolson

This comment has been minimized.

Show comment
Hide comment
@lukasolson

lukasolson Aug 3, 2017

Member

6.x (6.1.0): 8eff313
6.0 (6.0.0-rc1): e5b6450

Member

lukasolson commented Aug 3, 2017

6.x (6.1.0): 8eff313
6.0 (6.0.0-rc1): e5b6450

chrisronline added a commit to chrisronline/kibana that referenced this pull request Nov 20, 2017

Use ui-select for agg selector (elastic#13292)
* Use ui-select for agg selector

* Fix functional tests

* Fix functional tests

* Fix test

* Fix visualize page object

* Use sortPrefixFirst in agg selector

* Fix unit tests

* Fix unit test

* Use not(.ng-hide) rather than last-child

chrisronline added a commit to chrisronline/kibana that referenced this pull request Dec 1, 2017

Use ui-select for agg selector (elastic#13292)
* Use ui-select for agg selector

* Fix functional tests

* Fix functional tests

* Fix test

* Fix visualize page object

* Use sortPrefixFirst in agg selector

* Fix unit tests

* Fix unit test

* Use not(.ng-hide) rather than last-child

@lukasolson lukasolson deleted the lukasolson:trevan-use-ui-select-in-agg-selector branch Mar 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment