Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use find service instead of remote #13296

Merged

Conversation

Projects
None yet
2 participants
@stacey-gammon
Copy link
Contributor

commented Aug 2, 2017

Find service has built in checks for stale elements and such.

Fixes #13289

@stacey-gammon stacey-gammon force-pushed the stacey-gammon:tests/stabilize-dashboard-tests-2 branch from b48a2e5 to 4e3ad2b Aug 3, 2017

@stacey-gammon stacey-gammon force-pushed the stacey-gammon:tests/stabilize-dashboard-tests-2 branch from 79fd9bc to 937186d Aug 3, 2017

stacey-gammon added some commits Aug 3, 2017

@stacey-gammon stacey-gammon force-pushed the stacey-gammon:tests/stabilize-dashboard-tests-2 branch from 6877761 to 728f8d2 Aug 4, 2017

Did not realize WebElements could find descendants
Added some extra functionality for this in find and testSubjects
service, and using in the one place it’s required.
@stacey-gammon

This comment has been minimized.

Copy link
Contributor Author

commented Aug 4, 2017

Passed once,

jenkins test this

@stacey-gammon

This comment has been minimized.

Copy link
Contributor Author

commented Aug 4, 2017

Passed twice

Jenkins, test this

@stacey-gammon

This comment has been minimized.

Copy link
Contributor Author

commented Aug 4, 2017

Passed three times. I think that's sufficient.

@stacey-gammon stacey-gammon requested a review from nreese Aug 4, 2017

@nreese

nreese approved these changes Aug 8, 2017

Copy link
Contributor

left a comment

LGTM

@stacey-gammon stacey-gammon merged commit 9aed822 into elastic:master Aug 8, 2017

2 checks passed

CLA Commit author has signed the CLA
Details
kibana-ci Build finished.
Details

stacey-gammon added a commit to stacey-gammon/kibana that referenced this pull request Aug 8, 2017

Use find service instead of remote (elastic#13296)
* Use find service instead of remote which doesn't have built in safety checks for stale elements

* use data-test-subj instead of id

* add missing function and awaits

* Did not realize WebElements could find descendants

Added some extra functionality for this in find and testSubjects
service, and using in the one place it’s required.

stacey-gammon added a commit to stacey-gammon/kibana that referenced this pull request Aug 8, 2017

Use find service instead of remote (elastic#13296)
* Use find service instead of remote which doesn't have built in safety checks for stale elements

* use data-test-subj instead of id

* add missing function and awaits

* Did not realize WebElements could find descendants

Added some extra functionality for this in find and testSubjects
service, and using in the one place it’s required.

stacey-gammon added a commit that referenced this pull request Aug 8, 2017

Use find service instead of remote (#13296) (#13387)
* Use find service instead of remote which doesn't have built in safety checks for stale elements

* use data-test-subj instead of id

* add missing function and awaits

* Did not realize WebElements could find descendants

Added some extra functionality for this in find and testSubjects
service, and using in the one place it’s required.

stacey-gammon added a commit that referenced this pull request Aug 8, 2017

Use find service instead of remote (#13296) (#13388)
* Use find service instead of remote which doesn't have built in safety checks for stale elements

* use data-test-subj instead of id

* add missing function and awaits

* Did not realize WebElements could find descendants

Added some extra functionality for this in find and testSubjects
service, and using in the one place it’s required.

@stacey-gammon stacey-gammon deleted the stacey-gammon:tests/stabilize-dashboard-tests-2 branch Oct 24, 2017

chrisronline added a commit to chrisronline/kibana that referenced this pull request Nov 20, 2017

Use find service instead of remote (elastic#13296)
* Use find service instead of remote which doesn't have built in safety checks for stale elements

* use data-test-subj instead of id

* add missing function and awaits

* Did not realize WebElements could find descendants

Added some extra functionality for this in find and testSubjects
service, and using in the one place it’s required.

chrisronline added a commit to chrisronline/kibana that referenced this pull request Dec 1, 2017

Use find service instead of remote (elastic#13296)
* Use find service instead of remote which doesn't have built in safety checks for stale elements

* use data-test-subj instead of id

* add missing function and awaits

* Did not realize WebElements could find descendants

Added some extra functionality for this in find and testSubjects
service, and using in the one place it’s required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.