Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'all filters' actions keyboard accessible #13391

Merged
merged 2 commits into from Aug 9, 2017

Conversation

Projects
None yet
4 participants
@Bargs
Copy link
Contributor

commented Aug 8, 2017

Fixes #12640

"Actions" toggle and all of the actions links can now be accessed via the keyboard. I also added aria-expanded and aria-controls to the toggle link.

Bargs added some commits Aug 8, 2017

@timroes

timroes approved these changes Aug 8, 2017

Copy link
Contributor

left a comment

LGTM. Even though I would argue, that the a should actually be buttons, but this PR didn't introduced this :-) And the kbn-accessible-click directive will anyway give them role=button.

@Bargs

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2017

jenkins, test this

@Bargs Bargs merged commit 3b0c820 into elastic:master Aug 9, 2017

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
kibana-ci Build finished.
Details

Bargs added a commit to Bargs/kibana that referenced this pull request Aug 9, 2017

Make 'all filters' actions keyboard accessible (elastic#13391)
* Make 'all filters' actions keyboard accessible
* Add extra aria props to actions toggle

Bargs added a commit to Bargs/kibana that referenced this pull request Aug 9, 2017

Make 'all filters' actions keyboard accessible (elastic#13391)
* Make 'all filters' actions keyboard accessible
* Add extra aria props to actions toggle

Bargs added a commit that referenced this pull request Aug 9, 2017

Make 'all filters' actions keyboard accessible (#13391) (#13417)
* Make 'all filters' actions keyboard accessible
* Add extra aria props to actions toggle

Bargs added a commit that referenced this pull request Aug 9, 2017

Make 'all filters' actions keyboard accessible (#13391) (#13418)
* Make 'all filters' actions keyboard accessible
* Add extra aria props to actions toggle

chrisronline added a commit to chrisronline/kibana that referenced this pull request Nov 20, 2017

Make 'all filters' actions keyboard accessible (elastic#13391)
* Make 'all filters' actions keyboard accessible
* Add extra aria props to actions toggle

chrisronline added a commit to chrisronline/kibana that referenced this pull request Dec 1, 2017

Make 'all filters' actions keyboard accessible (elastic#13391)
* Make 'all filters' actions keyboard accessible
* Add extra aria props to actions toggle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.