Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intentionally show spy pane in full screen mode, but not embed mode #13395

Conversation

Projects
None yet
2 participants
@stacey-gammon
Copy link
Contributor

commented Aug 8, 2017

Fixes #13340

Doesn't actually change anything in the UI, since it worked this way before. However it worked this way accidentally (due to the static variable instead of binding via a function). Now we are binding via a function, but specifically allowing the spy pane toggle to show up in full screen mode, not embedded mode.

@spalger

spalger approved these changes Aug 8, 2017

Copy link
Member

left a comment

LGTM

@stacey-gammon stacey-gammon merged commit fb203ea into elastic:master Aug 9, 2017

2 checks passed

CLA Commit author has signed the CLA
Details
kibana-ci Build finished.
Details

stacey-gammon added a commit that referenced this pull request Aug 9, 2017

@stacey-gammon stacey-gammon deleted the stacey-gammon:fix/intentionally-show-spy-full-screen-mode branch Oct 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.