Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be case insensitive when sorting on the visualize and dashboard landing pages #13397

Merged

Conversation

Projects
None yet
3 participants
@stacey-gammon
Copy link
Contributor

commented Aug 8, 2017

Fixes #12233

Changes dashboard and visualize page to case insensitive sorting.

Before:
screen shot 2017-08-08 at 3 19 35 pm

After:
screen shot 2017-08-08 at 3 19 03 pm

@stacey-gammon stacey-gammon requested a review from cjcenizal Aug 8, 2017

@stacey-gammon stacey-gammon changed the title Be case insensitive when sorting on the visualize and dashboard landi… Be case insensitive when sorting on the visualize and dashboard landing pages Aug 8, 2017

@cjcenizal

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2017

@stacey-gammon Sorry, I'm swamped... removing myself as a reviewer. 🤕

@cjcenizal cjcenizal removed their request for review Aug 8, 2017

@stacey-gammon

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2017

no problem @cjcenizal! Just wanted to make sure you were aware since it changes the visualize landing page too, but I can def find someone else for the review.

@stacey-gammon stacey-gammon requested a review from timroes Aug 9, 2017

isAscending: true,
},
{
name: 'description',
getValue: item => item.description,
getValue: item => item.description.toLowerCase(),

This comment has been minimized.

Copy link
@tsullivan

tsullivan Aug 9, 2017

Contributor

Any chance this would throw an error if the description field is undefined?

This comment has been minimized.

Copy link
@stacey-gammon

stacey-gammon Aug 9, 2017

Author Contributor

Good point. It comes back as an empty string in practice, so no error. I could be extra safe and add a check for it, but the way the saved dashboards are filled with defaults, it will never be undefined, so that might be excessive checking. Not to say that things in the future might not change and eventually this could be undefined....

This comment has been minimized.

Copy link
@tsullivan

tsullivan Aug 9, 2017

Contributor

I just wanted to make sure. I don't think there is a need to change it as we don't need to guard against behavior that comes from our own code :)

Hopefully we will have functional testing in place before we would ever make a breaking change in the interface of the saved object. I'm not worried about it.

@tsullivan
Copy link
Contributor

left a comment

LGTM

@stacey-gammon stacey-gammon merged commit db4eb64 into elastic:master Aug 9, 2017

2 checks passed

CLA Commit author has signed the CLA
Details
kibana-ci Build finished.
Details

stacey-gammon added a commit to stacey-gammon/kibana that referenced this pull request Aug 9, 2017

stacey-gammon added a commit to stacey-gammon/kibana that referenced this pull request Aug 9, 2017

stacey-gammon added a commit that referenced this pull request Aug 11, 2017

stacey-gammon added a commit that referenced this pull request Aug 11, 2017

@stacey-gammon stacey-gammon deleted the stacey-gammon:fix/sort-case-insensitive branch Oct 24, 2017

chrisronline added a commit to chrisronline/kibana that referenced this pull request Nov 20, 2017

chrisronline added a commit to chrisronline/kibana that referenced this pull request Dec 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.