Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI Framework] [K7] Update uiFramework build task and webpack config to support themed CSS files. #13487

Merged
merged 1 commit into from Aug 14, 2017

Conversation

Projects
None yet
2 participants
@cjcenizal
Copy link
Contributor

commented Aug 11, 2017

@snide Here's an early birthday present for you! This adds a theme toggle to the UI Framework header.

theme_toggle

Update uiFramework build task and webpack config to support themed CS…
…S files.

- Add theme toggle to UI Framework header.

@cjcenizal cjcenizal requested a review from snide Aug 11, 2017

@snide

snide approved these changes Aug 14, 2017

Copy link
Contributor

left a comment

Awesome. This saves me a lot of time. Only thing I'm not sure of is whether there should be theme_dark/light variables when you already have a theme_dark.scss file. It's a little redundant. I think you could probably just get away with exposing the contents of that file in theme_dark.scss directly, which suddenly makes it a lot simpler to work with...

It's pretty minor and I'm not too concerned about it.

What theming obviously brings up is that there's no reason the docs themselves can't be written in the framework entirely at this point. Not the biggest issue for us, but I hate having to explain... "well, ignore this broken stuff, it's just coming from the documentation". Something to think about. Think it'd be a small half day project to convert.

@cjcenizal cjcenizal referenced this pull request Aug 14, 2017

Closed

K7 KUI #12807

36 of 51 tasks complete
@cjcenizal

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2017

@snide I ended up having to create those variables files so that we could compile the documentation site CSS as a separate file from the UI Framework CSS. So the build task now generates four CSS files: doc site light, doc site dark, KUI light, and KUI dark.

I think building the doc site out of the UI Framework components is interesting and has some attractive benefits, but I'm also hesitant to do so at this stage because the way we're building the dark theme now will only work if we commit to completely overhauling Kibana to use the new components, and we're not quite there yet. So the dark theme system has a huge potential upside, but I don't think we're prepared to realize it yet -- but once we are, I think we should revisit!

@cjcenizal cjcenizal merged commit b128db6 into elastic:k7-ui-framework Aug 14, 2017

1 check passed

CLA Commit author has signed the CLA
Details

@cjcenizal cjcenizal deleted the cjcenizal:k7/theme-toggle branch Aug 14, 2017

snide added a commit to snide/kibana that referenced this pull request Aug 14, 2017

Update uiFramework build task and webpack config to support themed CS…
…S files. (elastic#13487)

- Add theme toggle to UI Framework header.

cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Aug 16, 2017

Update uiFramework build task and webpack config to support themed CS…
…S files. (elastic#13487)

- Add theme toggle to UI Framework header.

cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Aug 26, 2017

Update uiFramework build task and webpack config to support themed CS…
…S files. (elastic#13487)

- Add theme toggle to UI Framework header.

cjcenizal added a commit that referenced this pull request Sep 19, 2017

Update uiFramework build task and webpack config to support themed CS…
…S files. (#13487)

- Add theme toggle to UI Framework header.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.