Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI Framework] KuiCheckbox and KuiSwitch visual bugs #13515

Merged

Conversation

Projects
None yet
2 participants
@cjcenizal
Copy link
Contributor

commented Aug 15, 2017

This was bugging me with KuiSwitch... there's a double border where the icon and body overlap.

Before:

image

After:

image

@cjcenizal cjcenizal requested a review from snide Aug 15, 2017

@snide

snide approved these changes Aug 15, 2017

Copy link
Contributor

left a comment

👍

@cjcenizal cjcenizal merged commit ea1bd9a into elastic:k7-ui-framework Aug 15, 2017

1 check passed

CLA Commit author has signed the CLA
Details

@cjcenizal cjcenizal deleted the cjcenizal:k7/checkbox-switch-states branch Aug 15, 2017

cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Aug 16, 2017

[UI Framework] KuiCheckbox and KuiSwitch visual bugs (elastic#13515)
* Retain focus state appearance on KuiCheckbox when it's being clicked on.
* Document KuiIcon check and lock types.
* Use KuiIcon inside of KuiSwitch to remove aliased border.

cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Aug 26, 2017

[UI Framework] KuiCheckbox and KuiSwitch visual bugs (elastic#13515)
* Retain focus state appearance on KuiCheckbox when it's being clicked on.
* Document KuiIcon check and lock types.
* Use KuiIcon inside of KuiSwitch to remove aliased border.

cjcenizal added a commit that referenced this pull request Sep 19, 2017

[UI Framework] KuiCheckbox and KuiSwitch visual bugs (#13515)
* Retain focus state appearance on KuiCheckbox when it's being clicked on.
* Document KuiIcon check and lock types.
* Use KuiIcon inside of KuiSwitch to remove aliased border.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.