Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fixed-scroll on Discover page #13516

Merged
merged 3 commits into from Aug 17, 2017

Conversation

Projects
None yet
3 participants
@Bargs
Copy link
Contributor

commented Aug 15, 2017

Some CSS changes were made in #10592
which caused the fixed-scroll directive to stop working in Discover.
Specifically the overflow rule which was added forced the width and
scrollWidth of the doc-container to be the same, so the fixed-scroll
directive would never add the scroll bar to the page. This PR simply
reverts the changes made in the above linked PR. I retested the original
issues in the latest version of Firefox and was unable to reproduce. It
seems that the original issues may have been fixed in Firefox itself.

Fixes #12416

Fix fixed-scroll on Discover page
Some CSS changes were made in
#10592
which caused the fixed-scroll directive to stop working in Discover.
Specifically the overflow rule which was added forced the width and
scrollWidth of the doc-container to be the same, so the fixed-scroll
directive would never add the scroll bar to the page. This PR simply
reverts the changes made in the above linked PR. I retested the original
issues in the latest version of Firefox and was unable to reproduce. It
seems that the original issues may have been fixed in Firefox itself.

Fixes #12416
@lukasolson
Copy link
Member

left a comment

Hmm, fresh download of Firefox 55.0.1 (64-bit) on MacOS:

image

What version of Firefox did you check?

@Bargs

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2017

@lukasolson I'm not seeing the problem in the screenshot?

@lukasolson

This comment has been minimized.

Copy link
Member

commented Aug 16, 2017

The problem is that there isn't a horizontal scrollbar. I thought that this was one of the issues the original PR intended to fix, but I guess it wasn't. When I've got master checked out, I see the horizontal scrollbar in dashboard even in Firefox.

Bargs added some commits Aug 16, 2017

@Bargs

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2017

@lukasolson ah gotcha, I was focused on the vertical scrollbar since that's what the original issue was pointing at. I just pushed take 2. The doc table container is now scrollable, but only when embedded in a dashboard panel.

@Bargs

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2017

I'll check out the test failure tomorrow

@stacey-gammon
Copy link
Contributor

left a comment

Everything seems to work as I would expect in Firefox, and Chrome, both on a dashboard and in Discover, with both vertical and horizontal scrollbars.

lgtm pending green ci

@Bargs

This comment has been minimized.

Copy link
Contributor Author

commented Aug 17, 2017

jenkins, test this

@lukasolson
Copy link
Member

left a comment

LGTM!

@Bargs Bargs merged commit e09b914 into elastic:master Aug 17, 2017

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
kibana-ci Build finished.
Details

Bargs added a commit to Bargs/kibana that referenced this pull request Aug 17, 2017

Fix fixed-scroll on Discover page (elastic#13516)
Some CSS changes were made in elastic#10592
which caused the fixed-scroll directive to stop working in Discover.
Specifically the overflow rule which was added forced the width and
scrollWidth of the doc-container to be the same, so the fixed-scroll
directive would never add the scroll bar to the page. This PR simply
reverts the changes made in the above linked PR. I retested the original
issues in the latest version of Firefox and was unable to reproduce. It
seems that the original issues may have been fixed in Firefox itself.

Fixes elastic#12416

Bargs added a commit to Bargs/kibana that referenced this pull request Aug 17, 2017

Fix fixed-scroll on Discover page (elastic#13516)
Some CSS changes were made in elastic#10592
which caused the fixed-scroll directive to stop working in Discover.
Specifically the overflow rule which was added forced the width and
scrollWidth of the doc-container to be the same, so the fixed-scroll
directive would never add the scroll bar to the page. This PR simply
reverts the changes made in the above linked PR. I retested the original
issues in the latest version of Firefox and was unable to reproduce. It
seems that the original issues may have been fixed in Firefox itself.

Fixes elastic#12416

Bargs added a commit to Bargs/kibana that referenced this pull request Aug 17, 2017

Fix fixed-scroll on Discover page (elastic#13516)
Some CSS changes were made in elastic#10592
which caused the fixed-scroll directive to stop working in Discover.
Specifically the overflow rule which was added forced the width and
scrollWidth of the doc-container to be the same, so the fixed-scroll
directive would never add the scroll bar to the page. This PR simply
reverts the changes made in the above linked PR. I retested the original
issues in the latest version of Firefox and was unable to reproduce. It
seems that the original issues may have been fixed in Firefox itself.

Fixes elastic#12416

Bargs added a commit that referenced this pull request Aug 17, 2017

Fix fixed-scroll on Discover page (#13516) (#13557)
Some CSS changes were made in #10592
which caused the fixed-scroll directive to stop working in Discover.
Specifically the overflow rule which was added forced the width and
scrollWidth of the doc-container to be the same, so the fixed-scroll
directive would never add the scroll bar to the page. This PR simply
reverts the changes made in the above linked PR. I retested the original
issues in the latest version of Firefox and was unable to reproduce. It
seems that the original issues may have been fixed in Firefox itself.

Fixes #12416

Bargs added a commit that referenced this pull request Aug 17, 2017

Fix fixed-scroll on Discover page (#13516) (#13559)
Some CSS changes were made in #10592
which caused the fixed-scroll directive to stop working in Discover.
Specifically the overflow rule which was added forced the width and
scrollWidth of the doc-container to be the same, so the fixed-scroll
directive would never add the scroll bar to the page. This PR simply
reverts the changes made in the above linked PR. I retested the original
issues in the latest version of Firefox and was unable to reproduce. It
seems that the original issues may have been fixed in Firefox itself.

Fixes #12416

Bargs added a commit that referenced this pull request Aug 17, 2017

Fix fixed-scroll on Discover page (#13516) (#13558)
Some CSS changes were made in #10592
which caused the fixed-scroll directive to stop working in Discover.
Specifically the overflow rule which was added forced the width and
scrollWidth of the doc-container to be the same, so the fixed-scroll
directive would never add the scroll bar to the page. This PR simply
reverts the changes made in the above linked PR. I retested the original
issues in the latest version of Firefox and was unable to reproduce. It
seems that the original issues may have been fixed in Firefox itself.

Fixes #12416

chrisronline added a commit to chrisronline/kibana that referenced this pull request Nov 20, 2017

Fix fixed-scroll on Discover page (elastic#13516)
Some CSS changes were made in elastic#10592
which caused the fixed-scroll directive to stop working in Discover.
Specifically the overflow rule which was added forced the width and
scrollWidth of the doc-container to be the same, so the fixed-scroll
directive would never add the scroll bar to the page. This PR simply
reverts the changes made in the above linked PR. I retested the original
issues in the latest version of Firefox and was unable to reproduce. It
seems that the original issues may have been fixed in Firefox itself.

Fixes elastic#12416

chrisronline added a commit to chrisronline/kibana that referenced this pull request Dec 1, 2017

Fix fixed-scroll on Discover page (elastic#13516)
Some CSS changes were made in elastic#10592
which caused the fixed-scroll directive to stop working in Discover.
Specifically the overflow rule which was added forced the width and
scrollWidth of the doc-container to be the same, so the fixed-scroll
directive would never add the scroll bar to the page. This PR simply
reverts the changes made in the above linked PR. I retested the original
issues in the latest version of Firefox and was unable to reproduce. It
seems that the original issues may have been fixed in Firefox itself.

Fixes elastic#12416
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.