Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix available metric aggs #13518

Merged

Conversation

thomasneirynck
Copy link
Contributor

@thomasneirynck thomasneirynck commented Aug 15, 2017

Closes #13267.

Unlike #13330, we are not refactoring how we reference these dependencies. That will be a separate effort.

This also does not fix #13517, which cannot be backported to v5.

@thomasneirynck thomasneirynck added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:fix v5.5.2 v5.6.0 v6.0.0 review labels Aug 15, 2017
@alexfrancoeur
Copy link

@thomasneirynck looks good for the most part, all aggregations seem to be there. There is some odd behavior when looking at Standard Deviation with the Arc visualization though. It looks to me like it's only applying the Arc to one of the bounds vs. both of them. Otherwise, it applies the circle viz.

screen shot 2017-08-16 at 12 52 53 pm

screen shot 2017-08-16 at 12 57 34 pm

Also as we discussed earlier, we'll need to get rid of the Geo Bounding aggregation at some point.

@thomasneirynck
Copy link
Contributor Author

^ that seems to be a bug. any chance you can create an issue for this?

Copy link

@alexfrancoeur alexfrancoeur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, opened #13562 to track the odd arc visualizations with standard deviation

@thomasneirynck thomasneirynck merged commit 5b43727 into elastic:master Aug 21, 2017
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Aug 21, 2017
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Aug 21, 2017
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Aug 21, 2017
@thomasneirynck
Copy link
Contributor Author

thomasneirynck commented Aug 21, 2017

Backports:
6.x: #13612
6.0: #13616
5.6: #13613
5.5: #13617

thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Aug 21, 2017
chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Nov 20, 2017
chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:fix review v5.5.3 v5.6.0 v6.0.0 v6.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should not show geo-bounds agg Kibana v.5.5.0+ Metric Visualization aggregation options missing
3 participants