[Visualize] Remove saved search references from all places on unlink #135628
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #135627
When trying to unlink a saved search from a vis which was saved before, the reference to the saved search wasn't actually removed because the reference was still retained in two places: The reference to the
savedSearch
object itself in vis instance and thesavedSearchId
in thevis.data
collection.This PR makes sure all references are cleanly removed from all places.