Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Invalidate api keys in agents default_api_key_history on force unenroll #135910

Merged
merged 2 commits into from Jul 8, 2022
Merged

[Fleet] Invalidate api keys in agents default_api_key_history on force unenroll #135910

merged 2 commits into from Jul 8, 2022

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Jul 7, 2022

Description

Resolve #134029

On force unenroll we revoke all the api keys of the agents, we were missing keys in default_api_key_history that contains api key between config change.
That PR solve by revoking these keys if they are present on the agent document.

@nchaulet nchaulet added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.4.0 labels Jul 7, 2022
@nchaulet nchaulet requested a review from a team as a code owner July 7, 2022 14:37
@nchaulet nchaulet self-assigned this Jul 7, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet nchaulet force-pushed the feature-invalidate-api-key-history branch from 54a6891 to e0d659a Compare July 7, 2022 15:03
@jen-huang jen-huang added release_note:fix and removed release_note:skip Skip the PR/issue when compiling release notes labels Jul 7, 2022
@juliaElastic
Copy link
Contributor

@elasticmachine merge upstream

juliaElastic
juliaElastic approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@juliaElastic
Copy link
Contributor

should this be backported as mentioned here? #134029 (comment)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
fleet 1380 1381 +1
Unknown metric groups

API count

id before after diff
fleet 1511 1513 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet
Copy link
Member Author

nchaulet commented Jul 8, 2022

should this be backported as mentioned here? #134029 (comment)

yes it probably make sense to backport it

@nchaulet nchaulet added v7.17.6 v8.3.3 auto-backport Deprecated: Automatically backport this PR after it's merged labels Jul 8, 2022
@nchaulet nchaulet merged commit 71dab14 into elastic:main Jul 8, 2022
@nchaulet nchaulet deleted the feature-invalidate-api-key-history branch July 8, 2022 12:37
kibanamachine pushed a commit that referenced this pull request Jul 8, 2022
@nchaulet
[Fleet] Invalidate api keys in agents default_api_key_history on forc…
720f482 
…e unenroll (#135910)

(cherry picked from commit 71dab14)
@kibanamachine kibanamachine mentioned this pull request Jul 8, 2022
Merged
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
❌ 7.17 Backport failed because of merge conflicts
✅ 8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 135910

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 8, 2022
@kibanamachine @nchaulet
[Fleet] Invalidate api keys in agents default_api_key_history on forc…
6ce7c8c 
…e unenroll (#135910) (#136007)

(cherry picked from commit 71dab14)

Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
@kibanamachine kibanamachine mentioned this pull request Aug 29, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliaElastic juliaElastic juliaElastic approved these changes

Assignees

@nchaulet nchaulet

Labels
auto-backport Deprecated: Automatically backport this PR after it's merged bug Fixes for quality problems that affect the customer experience release_note:fix Team:Fleet Team label for Observability Data Collection Fleet team v7.17.6 v8.3.3 v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet] Agent unenrollment should invalidate keys in default_api_key_history field
6 participants
@nchaulet @elasticmachine @juliaElastic @kibana-ci @kibanamachine @jen-huang