Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[npm] Upgrade wreck #13849

Merged
merged 1 commit into from Sep 15, 2017
Merged

[npm] Upgrade wreck #13849

merged 1 commit into from Sep 15, 2017

Conversation

@spalger
Copy link
Member

spalger commented Sep 5, 2017

This upgrades wreck to the latest version so that we get enhanced error handling and promise support. None of the breaking changes from 6.2 on impacted us, but in case you want to double check:

v7.0.0: es6-ified, node 4 required
v8.0.0: beforeRedirect functions must now call a callback when done
v9.0.0: hostname/port of request uri override hostname/port of baseUrl when both are specified
v10.0.0: wreck instances use unique event emitters
v11.0.0: 301 and 302 now use the original http method when redirecting, 400+ responses generate Boom errors, response event gets different args
v12.0.0: only shortcut methods create boom errors, not Wreck.request

@spalger spalger force-pushed the spalger:upgrage/wreck branch from 3b9da6d to 2ded9c0 Sep 5, 2017
Copy link
Member

tylersmalley left a comment

LGTM - what a bump! Tested builds and plugin installation and Console's proxy.

@tylersmalley tylersmalley requested a review from jbudz Sep 12, 2017
@jbudz
jbudz approved these changes Sep 12, 2017
@spalger spalger merged commit 7866a15 into elastic:master Sep 15, 2017
2 checks passed
2 checks passed
CLA Commit author has signed the CLA
Details
kibana-ci Build finished.
Details
@spalger spalger deleted the spalger:upgrage/wreck branch Sep 15, 2017
spalger added a commit that referenced this pull request Sep 15, 2017
(cherry picked from commit 7866a15)
spalger added a commit that referenced this pull request Sep 15, 2017
(cherry picked from commit 7866a15)
@spalger

This comment has been minimized.

Copy link
Member Author

spalger commented Sep 15, 2017

6.0: 738a1f1
6.1/6.x: b332998

@tylersmalley tylersmalley changed the title [npm] Upgrage wreck [npm] Upgrade wreck Sep 18, 2017
chrisronline added a commit to chrisronline/kibana that referenced this pull request Nov 20, 2017
chrisronline added a commit to chrisronline/kibana that referenced this pull request Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.