[ResponseOps][Alerting] Unable to upgrade to 8.4.0 when I have snoozed rules #139427

doakalexi · 2022-08-24T18:12:55Z

Resolves #139412

Summary

Added migration for 8.4.1 to remove isSnoozedUntil

Checklist

Unit or functional tests were updated or added to match the most common scenarios

elasticmachine · 2022-08-24T19:57:02Z

Pinging @elastic/response-ops (Team:ResponseOps)

ymao1

LGTM! Left one comment about another unit test but otherwise looks great.

I verified this locally by:

Running 8.2 and creating some rules:
- 8.2 rule never snoozed - didn't touch after creating
- 8.2 rule snoozed indefinitely in 8.2 - snoozed indefinitely after creating
- 8.2 rule snoozed for 1 day in 8.2 - snoozed for 1 day after creating
- 8.2 rule snoozed then unsnoozed in 8.2 - snoozed then unsnoozed after creating
- 8.2 rule snoozed indefinitely in 8.3 - didn't touch after creating
- 8.2 rule snoozed for 1 day in 8.3 - didn't touch after creating
- 8.2 rule snoozed then unsnoozed in 8.3 - didn't touch after creating
Upgraded to 8.3, verified the rules ran successfully then:
- snoozed the 8.2 rule snoozed indefinitely in 8.3 rule indefinitely
- snoozed the 8.2 rule snoozed for 1 day in 8.3 rule for 1 day
- snoozed then unsnoozed the 8.2 rule snoozed then unsnoozed in 8.3 rule
- then created:
  - 8.3 rule never snoozed - didn't touch after creating
  - 8.3 rule snoozed indefinitely in 8.3 - snoozed indefinitely after creating
  - 8.3 rule snoozed for 1 day in 8.3 - snoozed for 1 day after creating
  - 8.3 rule snoozed then unsnoozed in 8.3 - snoozed then unsnoozed after creating
Upgraded to 8.4 and saw the migration fail due to these rules:
- 8.2 rule snoozed for 1 day in 8.3
- 8.2 rule snoozed for 1 day in 8.2
- 8.3 rule snoozed for 1 day in 8.3
Ran this PR and saw the migration succeed. Snooze end date showed up correctly in the UI and saw the rules all run successfully.

x-pack/plugins/alerting/server/saved_objects/migrations.test.ts

gmmorris · 2022-08-25T08:16:43Z

x-pack/plugins/alerting/server/saved_objects/migrations.ts

+  return {
+    ...doc,
+    attributes: {
+      ...(omit(doc.attributes, ['isSnoozedUntil']) as RawRule),


I believe the result of this fix is that a rule that was snoozed in 8.3 will no longer be snoozed in 8.4.1.

Given the urgency I'm 👍 on that, but we should probably make that clear in the 8.4.1 release notes.

gmmorris · 2022-08-25T09:15:12Z

@Zacqary as you know the snooze functionality better than anyone - can you help us verify this?

I'm wondering what will happen to a rule that removed the isSnoozedUntil field but still retains a snoozeSchedule field. 🤔
Will the snooze still work under the hood but the UX will no longer reflect that it's snoozed?

ymao1 · 2022-08-25T11:50:45Z

I believe the result of this fix is that a rule that was snoozed in 8.3 will no longer be snoozed in 8.4.1.

@gmmorris When I tested this PR locally, I could still see the snooze in the UI after successful upgrade to 8.4. The PR that removed the mapping also calculates it on the fly, so I believe the snooze functionality should still work. Hopefully @Zacqary can confirm :)

kibana-ci · 2022-08-25T14:21:42Z

💚 Build Succeeded

Buildkite Build
Commit: a5bcf71

Metrics [docs]

✅ unchanged

History

💔 Build #67346 failed fc5a6b0
💛 Build #67216 was flaky 770a8e9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

mikecote

Changes LGTM! I can confirm the failed migraiton scenario no longer happens with this fix.

Zacqary · 2022-08-25T14:48:50Z

Will the snooze still work under the hood but the UX will no longer reflect that it's snoozed?

isSnoozedUntil should now be a field that's only added by the API and calculated when the user requests it, it's no longer present in the saved object at all. So no, there shouldn't be any UX issues.

kibanamachine · 2022-08-25T14:52:45Z

💔 All backports failed

Status	Branch	Result
❌	8.4	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 139427

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

doakalexi · 2022-08-25T15:05:16Z

💚 All backports created successfully

Status	Branch	Result
✅	8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…d rules (elastic#139427) * Adding migration * Removing timer * Adding functional test * Adding another test (cherry picked from commit 8991e04) # Conflicts: # x-pack/plugins/alerting/server/saved_objects/migrations.ts # x-pack/test/alerting_api_integration/spaces_only/tests/alerting/migrations.ts # x-pack/test/functional/es_archives/alerts/data.json

…d rules (#139427) (#139486) * Adding migration * Removing timer * Adding functional test * Adding another test (cherry picked from commit 8991e04) # Conflicts: # x-pack/plugins/alerting/server/saved_objects/migrations.ts # x-pack/test/alerting_api_integration/spaces_only/tests/alerting/migrations.ts # x-pack/test/functional/es_archives/alerts/data.json

…d rules (elastic#139427) * Adding migration * Removing timer * Adding functional test * Adding another test

doakalexi added 3 commits August 24, 2022 14:12

Adding migration

db19f41

Removing timer

3153840

Adding functional test

770a8e9

doakalexi changed the title ~~Adding migration~~ [ResponseOps][Alerting] Unable to upgrade to 8.4.0 when I have snoozed rules Aug 24, 2022

doakalexi added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) release_note:fix labels Aug 24, 2022

doakalexi marked this pull request as ready for review August 24, 2022 19:57

doakalexi requested a review from a team as a code owner August 24, 2022 19:57

ymao1 approved these changes Aug 25, 2022

View reviewed changes

x-pack/plugins/alerting/server/saved_objects/migrations.test.ts Outdated Show resolved Hide resolved

gmmorris reviewed Aug 25, 2022

View reviewed changes

doakalexi and others added 3 commits August 25, 2022 08:12

Adding another test

adf8d0f

Merge branch 'main' into alerting/8.4.1-migration

fc5a6b0

Merge branch 'main' into alerting/8.4.1-migration

a5bcf71

mikecote self-requested a review August 25, 2022 13:48

mikecote approved these changes Aug 25, 2022

View reviewed changes

mikecote added auto-backport Deprecated: Automatically backport this PR after it's merged v8.4.1 labels Aug 25, 2022

doakalexi merged commit 8991e04 into elastic:main Aug 25, 2022

doakalexi mentioned this pull request Aug 25, 2022

[8.4] [ResponseOps][Alerting] Unable to upgrade to 8.4.0 when I have snoozed rules (#139427) #139486

Merged

Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this pull request Sep 6, 2022

[ResponseOps][Alerting] Unable to upgrade to 8.4.0 when I have snooze…

533e59b

…d rules (elastic#139427) * Adding migration * Removing timer * Adding functional test * Adding another test

doakalexi deleted the alerting/8.4.1-migration branch December 6, 2022 19:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ResponseOps][Alerting] Unable to upgrade to 8.4.0 when I have snoozed rules #139427

[ResponseOps][Alerting] Unable to upgrade to 8.4.0 when I have snoozed rules #139427

doakalexi commented Aug 24, 2022 •

edited

elasticmachine commented Aug 24, 2022

ymao1 left a comment

gmmorris Aug 25, 2022

gmmorris commented Aug 25, 2022

ymao1 commented Aug 25, 2022

kibana-ci commented Aug 25, 2022

mikecote left a comment

Zacqary commented Aug 25, 2022 •

edited

kibanamachine commented Aug 25, 2022

doakalexi commented Aug 25, 2022

[ResponseOps][Alerting] Unable to upgrade to 8.4.0 when I have snoozed rules #139427

[ResponseOps][Alerting] Unable to upgrade to 8.4.0 when I have snoozed rules #139427

Conversation

doakalexi commented Aug 24, 2022 • edited

Summary

Checklist

elasticmachine commented Aug 24, 2022

ymao1 left a comment

Choose a reason for hiding this comment

gmmorris Aug 25, 2022

Choose a reason for hiding this comment

gmmorris commented Aug 25, 2022

ymao1 commented Aug 25, 2022

kibana-ci commented Aug 25, 2022

💚 Build Succeeded

Metrics [docs]

History

mikecote left a comment

Choose a reason for hiding this comment

Zacqary commented Aug 25, 2022 • edited

kibanamachine commented Aug 25, 2022

💔 All backports failed

Manual backport

Questions ?

doakalexi commented Aug 25, 2022

💚 All backports created successfully

Questions ?

doakalexi commented Aug 24, 2022 •

edited

Zacqary commented Aug 25, 2022 •

edited