[TSVB] Remove field_stats calls from 5.6 for TSVB #14152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simianhacker
added
Feature:TSVB
|
@simianhacker For courier requests in 5.6.0, we didn't remove field_stats entirely. Instead, we listened for the missing field_stats error and attempted the request again without field_stats if it was encountered. Since in the past, the lack of a field_stats preflight could take down clusters for some use cases, we just didn't want to risk accidentally doing that for folks unless they were definitely moving to 6.0. The PR was here #13670 |
simianhacker
force-pushed
the
fix-5.6-tsvb
branch
from
7631e46
to
d6c490d
Compare
simianhacker
force-pushed
the
fix-5.6-tsvb
branch
from
94d2a3c
to
f3e01f2
Compare
|
@epixa I changed the approach to essentially do the same. |
thomasneirynck
approved these changes
Sep 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
calcualte_indices.jsand changes the two files that used that function. I tried to keep the surface area of this change as small as possible which is why I decided to continue to return aPromisefor bothgetRequestParamsandgetAnnotations. This is only getting merged with 5.6 and the error it fixes only appears when the user had Kibana 5.6.x installed with ES 6.0.