Refine use of aria-label in Dashboard panel and top nav, Discover, and Management 'Edit index pattern' UI.

[cjcenizal]

This is a bit of a scattershot PR, but I just looked through our code for cases where we use aria-label and tried to apply spot fixes as I found issues.

[timroes]

I'm still a bit unsure about short vs. long aria-labels. Visually it totally makes sense to just print "Save" and "Load". They are places in the very top menu, and people (I assume - dunno if we have Usability tests to back that thesis) will understand, that this is a global action applying to the content of the complete page.

Since screen reader users have it a bit harder to get the overall context of an button they are currently in, and we also never have in any label for this menu, that all it's actions will apply to the dashboard and not maybe a single visualization they are viewing, or a dialog they might just have opened, I still think longer aria-labels could make sense here.

What are your opinions on that topic in general?

[cjcenizal]

I agree with your thoughts @timroes. It's a tough judgment call depending on the situation. For example, the original audit suggested we change "Load saved search" to "Open", but I think that removes too much context (#11532 (comment)).

But for Dashboard, I feel like the context is pretty clear. The breadcrumbs communicate that you're looking at a dashboard (as opposed to a visualization). So my gut tells me that it's unlikely that they'll get confused the way you describe. But I don't feel strongly about this (2/10) so since it seems like you feel more strongly about it I'll change it back.

[timroes]

Thanks. For these specific ones I would have also not too strong feelings (4/10 :D), but thought to bring up the topic in general. LGTM