Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Suppress error toast when data view cannot be created #143639

Merged
merged 2 commits into from Oct 19, 2022

Conversation

sorenlouv
Copy link
Member

Related to: #143336

Problem
APM UI will attempt to create a data view on initial page load:

useEffect(() => {
async function fetchDataView() {
const title = await getApmDataViewTitle();
return services.dataViews.create({ title });
}
fetchDataView().then(setDataView);
}, [services.dataViews]);

If the APM integration hasn't been installed, and no data has been ingested, it is not possible to create a data view and an error toast will be displayed

image

We don't want users to see this toast because they didn't initiate the action to create the data view

Solution

Suppress the toast

@sorenlouv sorenlouv requested a review from a team as a code owner October 19, 2022 11:42
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Oct 19, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

Copy link
Contributor

@gbamparop gbamparop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sorenlouv sorenlouv enabled auto-merge (squash) October 19, 2022 12:37
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.1MB 3.1MB +293.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv sorenlouv merged commit e363b7c into elastic:main Oct 19, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 19, 2022
kc13greiner pushed a commit to kc13greiner/kibana that referenced this pull request Oct 19, 2022
guskovaue pushed a commit to guskovaue/kibana that referenced this pull request Oct 22, 2022
@sorenlouv sorenlouv deleted the suppress-toast-no-data branch October 22, 2022 19:39
e40pud pushed a commit to e40pud/kibana that referenced this pull request Oct 24, 2022
@sorenlouv sorenlouv added v8.5.2 auto-backport Deprecated: Automatically backport this PR after it's merged labels Nov 17, 2022
kibanamachine pushed a commit that referenced this pull request Nov 17, 2022
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated: Automatically backport this PR after it's merged backport:skip This commit does not require backporting release_note:fix Team:APM All issues that need APM UI Team support v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants