[APM] Extracting serviceGroupApiMethods to avoid duplication of code #149026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yngrdyn
added
the
release_note:skip
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
sorenlouv
reviewed
Jan 17, 2023
Comment on lines
+24
to
+29
| apmApiClient: ApmApiClient; | ||
| serviceGroupId?: string; | ||
| groupName: string; | ||
| kuery: string; | ||
| description?: string; | ||
| color?: string; |
There was a problem hiding this comment.
What about using the ServiceGroup type that already exist, and use a similar interface to this:
Suggested change
| apmApiClient: ApmApiClient; | |
| serviceGroupId?: string; | |
| groupName: string; | |
| kuery: string; | |
| description?: string; | |
| color?: string; | |
| apmApiClient: ApmApiClient; | |
| serviceGroupId?: string; | |
| serviceGroup: ServiceGroup |
sorenlouv
reviewed
Jan 17, 2023
Comment on lines
+37
to
+42
| body: { | ||
| groupName, | ||
| kuery, | ||
| description, | ||
| color, | ||
| }, |
There was a problem hiding this comment.
This would then be:
Suggested change
| body: { | |
| groupName, | |
| kuery, | |
| description, | |
| color, | |
| }, | |
| body: serviceGroup, |
There was a problem hiding this comment.
I'm getting this
The only way to reuse the type is doing something like this
Should we still use it?
kibanamachine
added
v8.7.0
backport:skip
wayneseymour
pushed a commit
to wayneseymour/kibana
that referenced
this pull request
Jan 19, 2023
…lastic#149026) Closes elastic#148280. ### Changes - Created `ApmApiClient` type. - Extracted service groups api methods to reuse in `save_service_groups` and `service_group_count` tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #148280.
Changes
ApmApiClienttype.save_service_groupsandservice_group_counttests.