From ef9b583990702f91aa72c438e709f998e144b85a Mon Sep 17 00:00:00 2001
From: bhavyarm <bhavya.mayur@gmail.com>
Date: Tue, 21 Nov 2017 16:43:08 -0500
Subject: [PATCH 1/2] 
 src/core_plugins/kibana/public/home/components/synopsis.js

---
 .../kibana/public/home/components/synopsis.js |  6 +++-
 .../directives/global_nav/global_nav.html     |  2 +-
 test/functional/apps/home/_home.js            | 30 +++++++++++++++++++
 test/functional/apps/home/index.js            | 13 ++++++++
 test/functional/config.js                     |  3 ++
 test/functional/page_objects/home_page.js     | 30 +++++++++++++++++++
 test/functional/page_objects/index.js         |  1 +
 7 files changed, 83 insertions(+), 2 deletions(-)
 create mode 100644 test/functional/apps/home/_home.js
 create mode 100644 test/functional/apps/home/index.js
 create mode 100644 test/functional/page_objects/home_page.js

diff --git a/src/core_plugins/kibana/public/home/components/synopsis.js b/src/core_plugins/kibana/public/home/components/synopsis.js
index 56a0fb7145e61..a336d777860e0 100644
--- a/src/core_plugins/kibana/public/home/components/synopsis.js
+++ b/src/core_plugins/kibana/public/home/components/synopsis.js
@@ -19,7 +19,11 @@ export function Synopsis({ description, iconUrl, title, url }) {
   }
 
   return (
-    <a href={url} className="kuiLink synopsis">
+    <a
+      href={url}
+      className="kuiLink synopsis"
+      data-test-subj={`homeSynopsisLink${title.toLowerCase()}`}
+    >
       <KuiFlexGroup>
         <KuiFlexItem grow={false}>{img}</KuiFlexItem>
         <KuiFlexItem className="synopsisContent">
diff --git a/src/ui/public/chrome/directives/global_nav/global_nav.html b/src/ui/public/chrome/directives/global_nav/global_nav.html
index 828ccd9d7a191..156fe572d7bc7 100644
--- a/src/ui/public/chrome/directives/global_nav/global_nav.html
+++ b/src/ui/public/chrome/directives/global_nav/global_nav.html
@@ -6,7 +6,7 @@
 
   <!-- Logo -->
   <div class="global-nav__logo">
-    <a href="{{ getHref('/app/kibana#/home') }}">
+    <a href="{{ getHref('/app/kibana#/home') }}" data-test-subj="kibanaLogo">
       <li
         ng-if="!logoBrand && !smallLogoBrand"
         aria-label="{{ appTitle }} Logo"
diff --git a/test/functional/apps/home/_home.js b/test/functional/apps/home/_home.js
new file mode 100644
index 0000000000000..bcc45149310ff
--- /dev/null
+++ b/test/functional/apps/home/_home.js
@@ -0,0 +1,30 @@
+import expect from 'expect.js';
+
+
+export default function ({ getService, getPageObjects }) {
+  const retry = getService('retry');
+  const log = getService('log');
+  const dashboardVisualizations = getService('dashboardVisualizations');
+  const remote = getService('remote');
+  const PageObjects = getPageObjects(['common', 'home']);
+
+  describe('Kibana takes you home', function describeIndexTests() {
+
+    it('clicking on kibana app should take you to home page', async ()=> {
+        await PageObjects.common.navigateToApp('settings');
+        log.debug("homepage nav");
+        await PageObjects.home.clickKibanaIcon();
+        const url = await remote.getCurrentUrl();
+        expect(url.includes('/app/kibana#/home')).to.be(true);
+
+    });
+
+    it('clicking on console on homepage should take you to console app', async ()=> {
+        await PageObjects.home.clickSynopsis('console');
+        const url = await remote.getCurrentUrl();
+        expect(url.includes('/app/kibana#/dev_tools/console?_g=()')).to.be(true);
+
+    });
+
+  });
+}
diff --git a/test/functional/apps/home/index.js b/test/functional/apps/home/index.js
new file mode 100644
index 0000000000000..d5f27658cb583
--- /dev/null
+++ b/test/functional/apps/home/index.js
@@ -0,0 +1,13 @@
+export default function ({ getService, loadTestFile }) {
+  const esArchiver = getService('esArchiver');
+  const remote = getService('remote');
+
+  describe('homepage app', function () {
+    before(function () {
+      return remote.setWindowSize(1200, 800);
+    });
+
+    loadTestFile(require.resolve('./_home'));
+
+  });
+}
diff --git a/test/functional/config.js b/test/functional/config.js
index 20f76629431aa..be97a56798fe1 100644
--- a/test/functional/config.js
+++ b/test/functional/config.js
@@ -5,6 +5,7 @@ import {
   ContextPageProvider,
   DiscoverPageProvider,
   HeaderPageProvider,
+  HomePageProvider,
   DashboardPageProvider,
   VisualizePageProvider,
   SettingsPageProvider,
@@ -34,6 +35,7 @@ export default async function ({ readConfigFile }) {
       require.resolve('./apps/context'),
       require.resolve('./apps/dashboard'),
       require.resolve('./apps/discover'),
+      require.resolve('./apps/home'),
       require.resolve('./apps/management'),
       require.resolve('./apps/status_page'),
       require.resolve('./apps/visualize'),
@@ -46,6 +48,7 @@ export default async function ({ readConfigFile }) {
       context: ContextPageProvider,
       discover: DiscoverPageProvider,
       header: HeaderPageProvider,
+      home: HomePageProvider,
       dashboard: DashboardPageProvider,
       visualize: VisualizePageProvider,
       settings: SettingsPageProvider,
diff --git a/test/functional/page_objects/home_page.js b/test/functional/page_objects/home_page.js
new file mode 100644
index 0000000000000..ff89b375cbcbd
--- /dev/null
+++ b/test/functional/page_objects/home_page.js
@@ -0,0 +1,30 @@
+import _ from 'lodash';
+
+export function HomePageProvider({ getService, getPageObjects }) {
+  const log = getService('log');
+  const find = getService('find');
+  const retry = getService('retry');
+  const config = getService('config');
+  const remote = getService('remote');
+  const esArchiver = getService('esArchiver');
+  const kibanaServer = getService('kibanaServer');
+  const testSubjects = getService('testSubjects');
+  const PageObjects = getPageObjects(['common', 'header']);
+
+  const defaultFindTimeout = config.get('timeouts.find');
+
+  class HomePage {
+
+    async clickKibanaIcon() {
+      await testSubjects.click('kibanaLogo');
+    }
+
+    async clickSynopsis(title){
+      await testSubjects.click(`homeSynopsisLink${title}`);
+    }
+
+
+  }
+
+  return new HomePage();
+}
diff --git a/test/functional/page_objects/index.js b/test/functional/page_objects/index.js
index 669775b73d564..e980bff981611 100644
--- a/test/functional/page_objects/index.js
+++ b/test/functional/page_objects/index.js
@@ -4,6 +4,7 @@ export { ShieldPageProvider } from './shield_page';
 export { ContextPageProvider } from './context_page';
 export { DiscoverPageProvider } from './discover_page';
 export { HeaderPageProvider } from './header_page';
+export { HomePageProvider } from './home_page';
 export { DashboardPageProvider } from './dashboard_page';
 export { VisualizePageProvider } from './visualize_page';
 export { SettingsPageProvider } from './settings_page';

From 94f973b8b4512525832bbcb5f1702367412604f9 Mon Sep 17 00:00:00 2001
From: bhavyarm <bhavya.mayur@gmail.com>
Date: Tue, 21 Nov 2017 16:47:24 -0500
Subject: [PATCH 2/2] test/functional/apps/home/_home.js

---
 test/functional/apps/home/_home.js        | 22 ++++++++--------------
 test/functional/apps/home/index.js        |  2 --
 test/functional/page_objects/home_page.js | 17 +++--------------
 3 files changed, 11 insertions(+), 30 deletions(-)

diff --git a/test/functional/apps/home/_home.js b/test/functional/apps/home/_home.js
index bcc45149310ff..a68784b9489e3 100644
--- a/test/functional/apps/home/_home.js
+++ b/test/functional/apps/home/_home.js
@@ -2,28 +2,22 @@ import expect from 'expect.js';
 
 
 export default function ({ getService, getPageObjects }) {
-  const retry = getService('retry');
-  const log = getService('log');
-  const dashboardVisualizations = getService('dashboardVisualizations');
   const remote = getService('remote');
   const PageObjects = getPageObjects(['common', 'home']);
 
   describe('Kibana takes you home', function describeIndexTests() {
 
-    it('clicking on kibana app should take you to home page', async ()=> {
-        await PageObjects.common.navigateToApp('settings');
-        log.debug("homepage nav");
-        await PageObjects.home.clickKibanaIcon();
-        const url = await remote.getCurrentUrl();
-        expect(url.includes('/app/kibana#/home')).to.be(true);
-
+    it('clicking on kibana logo should take you to home page', async ()=> {
+      await PageObjects.common.navigateToApp('settings');
+      await PageObjects.home.clickKibanaIcon();
+      const url = await remote.getCurrentUrl();
+      expect(url.includes('/app/kibana#/home')).to.be(true);
     });
 
     it('clicking on console on homepage should take you to console app', async ()=> {
-        await PageObjects.home.clickSynopsis('console');
-        const url = await remote.getCurrentUrl();
-        expect(url.includes('/app/kibana#/dev_tools/console?_g=()')).to.be(true);
-
+      await PageObjects.home.clickSynopsis('console');
+      const url = await remote.getCurrentUrl();
+      expect(url.includes('/app/kibana#/dev_tools/console?_g=()')).to.be(true);
     });
 
   });
diff --git a/test/functional/apps/home/index.js b/test/functional/apps/home/index.js
index d5f27658cb583..cad5e2b98f62f 100644
--- a/test/functional/apps/home/index.js
+++ b/test/functional/apps/home/index.js
@@ -1,5 +1,4 @@
 export default function ({ getService, loadTestFile }) {
-  const esArchiver = getService('esArchiver');
   const remote = getService('remote');
 
   describe('homepage app', function () {
@@ -8,6 +7,5 @@ export default function ({ getService, loadTestFile }) {
     });
 
     loadTestFile(require.resolve('./_home'));
-
   });
 }
diff --git a/test/functional/page_objects/home_page.js b/test/functional/page_objects/home_page.js
index ff89b375cbcbd..7f8b0605d3c30 100644
--- a/test/functional/page_objects/home_page.js
+++ b/test/functional/page_objects/home_page.js
@@ -1,25 +1,14 @@
-import _ from 'lodash';
 
-export function HomePageProvider({ getService, getPageObjects }) {
-  const log = getService('log');
-  const find = getService('find');
-  const retry = getService('retry');
-  const config = getService('config');
-  const remote = getService('remote');
-  const esArchiver = getService('esArchiver');
-  const kibanaServer = getService('kibanaServer');
+export function HomePageProvider({ getService }) {
   const testSubjects = getService('testSubjects');
-  const PageObjects = getPageObjects(['common', 'header']);
-
-  const defaultFindTimeout = config.get('timeouts.find');
-
+  //const PageObjects = getPageObjects(['common', 'header']);
   class HomePage {
 
     async clickKibanaIcon() {
       await testSubjects.click('kibanaLogo');
     }
 
-    async clickSynopsis(title){
+    async clickSynopsis(title) {
       await testSubjects.click(`homeSynopsisLink${title}`);
     }