New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allows to hide warnings in gauge #15139

Merged
merged 4 commits into from Nov 29, 2017

Conversation

Projects
None yet
3 participants
@ppisljar
Member

ppisljar commented Nov 23, 2017

Release Note: Users can now opt-out of having gauges display warnings.


resolves #13436

@ppisljar ppisljar requested a review from nreese Nov 23, 2017

<div class="kuiSideBarFormRow">
<label class="kuiSideBarFormRow__label" for="displayWarnings">
Display warnings &nbsp;
<kbn-info info="Turns on/off warnings. When turned on, warning will be shown for each term that cannot be matched to a shape in the vector layer based on the join field. When turned off, these warnings will be turned off."></kbn-info>

This comment has been minimized.

@timroes

timroes Nov 28, 2017

Contributor

"a warning will be shown" or "warnings will be shown"

This comment has been minimized.

@thomasneirynck

thomasneirynck Nov 28, 2017

Contributor

This is not the correct warning message it seems like. Something like

Consider:

Turns on/off warnings. When turned on, a warning will be shown if not all labels could be displayed.

@@ -150,6 +150,7 @@ export function MeterGaugeProvider() {
const marginFactor = 0.95;
const tooltip = this.gaugeChart.tooltip;
const isTooltip = this.gaugeChart.handler.visConfig.get('addTooltip');
const isDisplayWarning = this.gaugeChart.handler.visConfig.get('isDisplayWarning', true);

This comment has been minimized.

@timroes

timroes Nov 28, 2017

Contributor

If the true can be removed, since it's the default value anyway it should be.

<div class="kuiSideBarFormRow">
<label class="kuiSideBarFormRow__label" for="displayWarnings">
Display warnings &nbsp;
<kbn-info info="Turns on/off warnings. When turned on, warning will be shown for each term that cannot be matched to a shape in the vector layer based on the join field. When turned off, these warnings will be turned off."></kbn-info>

This comment has been minimized.

@thomasneirynck

thomasneirynck Nov 28, 2017

Contributor

This is not the correct warning message it seems like. Something like

Consider:

Turns on/off warnings. When turned on, a warning will be shown if not all labels could be displayed.

@@ -21,7 +21,7 @@ export default function GaugeVisType(Private) {
type: 'gauge',
addTooltip: true,
addLegend: true,
isDisplayWarning: true,

This comment has been minimized.

@thomasneirynck

thomasneirynck Nov 28, 2017

Contributor

I'd turn this off by default. I understand this is a very slight incompatible change, but I think it's worth it.

@ppisljar ppisljar merged commit b787206 into elastic:master Nov 29, 2017

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
kibana-ci Build finished.
Details

ppisljar added a commit to ppisljar/kibana that referenced this pull request Nov 29, 2017

allows to hide warnings in gauge (elastic#15139)
* allows to hide warnings in gauge

* should default to true if option is not set

* fixing based on review

* default for isDisplayWarning needs to be applied, else it fails

ppisljar added a commit to ppisljar/kibana that referenced this pull request Nov 29, 2017

allows to hide warnings in gauge (elastic#15139)
* allows to hide warnings in gauge

* should default to true if option is not set

* fixing based on review

* default for isDisplayWarning needs to be applied, else it fails

ppisljar added a commit to ppisljar/kibana that referenced this pull request Nov 29, 2017

allows to hide warnings in gauge (elastic#15139)
* allows to hide warnings in gauge

* should default to true if option is not set

* fixing based on review

* default for isDisplayWarning needs to be applied, else it fails

ppisljar added a commit to ppisljar/kibana that referenced this pull request Nov 29, 2017

allows to hide warnings in gauge (elastic#15139)
* allows to hide warnings in gauge

* should default to true if option is not set

* fixing based on review

* default for isDisplayWarning needs to be applied, else it fails

ppisljar added a commit that referenced this pull request Nov 29, 2017

allows to hide warnings in gauge (#15139) (#15238)
* allows to hide warnings in gauge

* should default to true if option is not set

* fixing based on review

* default for isDisplayWarning needs to be applied, else it fails

ppisljar added a commit that referenced this pull request Nov 29, 2017

allows to hide warnings in gauge (#15139) (#15239)
* allows to hide warnings in gauge

ppisljar added a commit that referenced this pull request Nov 29, 2017

allows to hide warnings in gauge (#15139) (#15240)
* allows to hide warnings in gauge

ppisljar added a commit that referenced this pull request Nov 29, 2017

allows to hide warnings in gauge (#15139) (#15241)
* allows to hide warnings in gauge

chrisronline added a commit to chrisronline/kibana that referenced this pull request Dec 1, 2017

allows to hide warnings in gauge (elastic#15139)
* allows to hide warnings in gauge

* should default to true if option is not set

* fixing based on review

* default for isDisplayWarning needs to be applied, else it fails
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment