New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parsedUrl to the code driving viz/dashboards #15335

Merged
merged 1 commit into from Dec 1, 2017

Conversation

Projects
None yet
4 participants
@chrisronline
Contributor

chrisronline commented Dec 1, 2017

Ensures relative urls still work in visualizations and dashboards

Fixes #15336

@Stacey-Gammon

lgtm

@epixa

This comment has been minimized.

Member

epixa commented Dec 1, 2017

Are there tests for toString that we can update to verify this behavior?

@chrisronline

This comment has been minimized.

Contributor

chrisronline commented Dec 1, 2017

@epixa I didn't see any to update so I thought about adding a new one, but I wasn't sure the scope so decided to make a ticket to follow up with the tests in a later PR.

@epixa

epixa approved these changes Dec 1, 2017

LGTM

@roncohen

This comment has been minimized.

roncohen commented Dec 1, 2017

I can confirm that this fixes the regression that we saw with dashboard urls in the APM dashboards

@chrisronline chrisronline merged commit f59578a into elastic:master Dec 1, 2017

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
kibana-ci Build finished.
Details

chrisronline added a commit to chrisronline/kibana that referenced this pull request Dec 1, 2017

chrisronline added a commit to chrisronline/kibana that referenced this pull request Dec 1, 2017

chrisronline added a commit to chrisronline/kibana that referenced this pull request Dec 1, 2017

chrisronline added a commit to chrisronline/kibana that referenced this pull request Dec 1, 2017

chrisronline added a commit that referenced this pull request Dec 1, 2017

chrisronline added a commit that referenced this pull request Dec 1, 2017

@chrisronline chrisronline deleted the chrisronline:fix/relative-url-dashboards branch Dec 1, 2017

chrisronline added a commit that referenced this pull request Dec 1, 2017

chrisronline added a commit to chrisronline/kibana that referenced this pull request Dec 1, 2017

chrisronline added a commit that referenced this pull request Dec 4, 2017

@chrisronline

This comment has been minimized.

Contributor

chrisronline commented Dec 4, 2017

Backport

6.x: 21bcc93
6.1: 40550a8
6.0: 35970c5
5.6: 362722a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment