Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
other and missing bucket support for terms agg #15525
release note: 'other' and 'missing' bucket for the terms aggregation
@ppisljar looking good! A few comments, observations and open questions below.
I'm not sure if this is a side effect of other or a pie charts normal approach for visualizing too many slices in a small area. It looks like one single white value, maybe there's a better way for handling this.
my answers to open questions:
referenced this pull request
Dec 14, 2017
sweeto! this is going to be a yuge addition.
This is an early PR, so some of my comments might be stale (if so, then ignore).
There's two things to evaluate I think:
- I would decouple others and missing in two separte checkbox UIs.
- I'd do determination of what the actual query has to become up front, in a pre-flight request instead of a postFlight request. It'd preserve the contract of
@ppisljar some quick weekend feedback.
I noticed that the behavior of an empty pie chart is a bit odd. Not sure if it's related to the PR. At first I didn't realize I was missing data, just thought that there was an issue loading the pie chart. However, if I resize the window the error message occurs. Check out this gif
A couple of additional comments below.
As a Kibana end user - I don't know the difference between
Should a user have a choice to choose a missing and/or other bucket? I understand that elasticsearch uses
I feel we're running into issues here within the UI that we have in the past, using elasticsearch terminology vs. what would be intuitive for building the visualization. I don't have any good recommendations at the moment but it's something to think about. Maybe we can discuss some options early next week?
I tried to break it and haven't found a way so far. Everything seems to work as expected, even if you try to nest different aggregations in weird ways.
I have some more code suggestions and questions, but since I am now away for 2 weeks, these shouldn't block this PR if it would get ready otherwise.
Also I would like to see some more tests and documentation (especially in the
terms_other_bucket_helper file), but that's anyway on the todo list.