Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Initial serverless functional tests for ML #167493

Merged

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Sep 28, 2023

Add serverless functional tests for each project.

Search
Opens the trained models page and checks that there are 4 models listed.

Observability
Creates a AD job and then navigates to the AD jobs list and checks that the job is listed.

Security
Creates a AD job and then navigates to the AD jobs list and checks that the job is listed.
Creates a DFA job and then navigates to the DFA jobs list and checks that the job is listed.
Navigates to the trained models page and checks that there are no trained models listed.

Also adds tests for each project to ensure that kibana search bar only lists the pages which are enabled.

@jgowdyelastic jgowdyelastic self-assigned this Sep 29, 2023
@jgowdyelastic jgowdyelastic added :ml release_note:skip Skip the PR/issue when compiling release notes v8.11.0 labels Sep 29, 2023
@jgowdyelastic jgowdyelastic marked this pull request as ready for review September 29, 2023 14:58
@jgowdyelastic jgowdyelastic requested review from a team as code owners September 29, 2023 14:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

await navigateToArea('dataFrameAnalytics');
},
async navigateToTrainedModels() {
await navigateToArea('nodesOverview');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ the identifier is quite misleading. why do we refer to Trained Models with nodesOverview id?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nodesOverview is the ID which has been used in the default navigation for the model management page. I believe it's a leftover from when the model management page also listed node and memory usage information.
I have a note to correct it, but it'll touch a few files and is out of scope for this tests PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

navigateToArea is the name of an existing function in the non-serverless tests. I agree that it's an odd name, but I wanted it all to be consistent.

Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.5MB 3.5MB -5.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic jgowdyelastic merged commit fe7d2eb into elastic:main Oct 3, 2023
20 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants