-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Initial serverless functional tests for ML #167493
[ML] Initial serverless functional tests for ML #167493
Conversation
Pinging @elastic/ml-ui (:ml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
x-pack/test_serverless/functional/test_suites/search/ml/index.ts
Outdated
Show resolved
Hide resolved
x-pack/test_serverless/functional/test_suites/observability/ml/index.ts
Outdated
Show resolved
Hide resolved
await navigateToArea('dataFrameAnalytics'); | ||
}, | ||
async navigateToTrainedModels() { | ||
await navigateToArea('nodesOverview'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ the identifier is quite misleading. why do we refer to Trained Models
with nodesOverview
id?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nodesOverview
is the ID which has been used in the default navigation for the model management page. I believe it's a leftover from when the model management page also listed node and memory usage information.
I have a note to correct it, but it'll touch a few files and is out of scope for this tests PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
navigateToArea
is the name of an existing function in the non-serverless tests. I agree that it's an odd name, but I wanted it all to be consistent.
x-pack/test_serverless/functional/test_suites/observability/ml/anomaly_detection_jobs_list.ts
Outdated
Show resolved
Hide resolved
x-pack/test_serverless/functional/test_suites/search/ml/trained_models_list.ts
Outdated
Show resolved
Hide resolved
x-pack/test_serverless/functional/test_suites/security/ml/data_frame_analytics_jobs_list.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add serverless functional tests for each project.
Search
Opens the trained models page and checks that there are 4 models listed.
Observability
Creates a AD job and then navigates to the AD jobs list and checks that the job is listed.
Security
Creates a AD job and then navigates to the AD jobs list and checks that the job is listed.
Creates a DFA job and then navigates to the DFA jobs list and checks that the job is listed.
Navigates to the trained models page and checks that there are no trained models listed.
Also adds tests for each project to ensure that kibana search bar only lists the pages which are enabled.