Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eui dashboard listing #16967

Merged
merged 21 commits into from Apr 26, 2018

Conversation

Projects
None yet
5 participants
@nreese
Copy link
Contributor

nreese commented Mar 5, 2018

Convert dashboard listing page to react and EUI

screen shot 2018-03-13 at 3 20 09 pm

@nreese nreese added the WIP label Mar 5, 2018

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 5, 2018

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 5, 2018

@nreese nreese force-pushed the nreese:euiDashboardListing branch from 4fdfc50 to 80264ab Mar 9, 2018

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 9, 2018

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 9, 2018

@nreese nreese force-pushed the nreese:euiDashboardListing branch from 69f3f0f to 1b80508 Mar 12, 2018

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 12, 2018

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 12, 2018

@nreese nreese force-pushed the nreese:euiDashboardListing branch from c16a081 to a706b00 Mar 13, 2018

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 13, 2018

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 13, 2018

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 14, 2018

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 15, 2018

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 15, 2018

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 16, 2018

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 16, 2018

@nreese nreese force-pushed the nreese:euiDashboardListing branch from f22d3b7 to 25230f9 Mar 16, 2018

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 16, 2018

@nreese

This comment has been minimized.

Copy link
Contributor Author

nreese commented Mar 16, 2018

jenkins, test this

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 16, 2018

@nreese nreese force-pushed the nreese:euiDashboardListing branch from 25230f9 to 759fdec Mar 17, 2018

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 17, 2018

@nreese nreese requested review from stacey-gammon and chrisdavies Mar 19, 2018

@nreese nreese added v7.0.0 v6.3.0 and removed WIP labels Mar 19, 2018

@nreese

This comment has been minimized.

Copy link
Contributor Author

nreese commented Mar 19, 2018

This PR is finally ready for review.

The functional tests are failing because EuiSearchBox input can get out of sync. For example, typing Dashboard Listing Test becomes Dashboard Listing Tst. Once this happens, the tests fail because PageObjects.dashboard.selectDashboard can not find the required dashboard because it is filtered away. I have a PR out for EUI that should resolve this issue but the PR can be reviewed while EUI gets fixed.

@stacey-gammon

This comment has been minimized.

Copy link
Contributor

stacey-gammon commented Mar 19, 2018

I get a couple console warnings when I first load up the page:
screen shot 2018-03-19 at 10 24 26 am

@nreese nreese force-pushed the nreese:euiDashboardListing branch from d640c9c to 0518ead Apr 25, 2018

@nreese

This comment has been minimized.

Copy link
Contributor Author

nreese commented Apr 25, 2018

@stacey-gammon I have rebased this PR and it should be good for a final look.

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Apr 25, 2018

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Apr 25, 2018

@stacey-gammon
Copy link
Contributor

stacey-gammon left a comment

Everything looks and is working great, only thing I think should change is to add back in the edit link, to avoid any fallback from users. But otherwise, LGTM!!! 🎉 🎉

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Apr 26, 2018

@nreese nreese merged commit bed97a2 into elastic:master Apr 26, 2018

2 checks passed

CLA Commit author has signed the CLA
Details
kibana-ci Build finished.
Details

nreese added a commit to nreese/kibana that referenced this pull request Apr 26, 2018

Eui dashboard listing (elastic#16967)
* convert dashboard listing page to react and EUI

* add jest test for DashboardListing component

* add data-test-subj attributes

* clean up jest test

* hideWriteControls and call to action when no dashboards exist

* pass initial filter to dashboard listing, get functional tests to work

* fix dashboard queries functional tests

* upgraded to EUI 0.0.29 to get defaultFocusedButton fix

* move dashboardListing directive to index

* spacing in if statement

* switch to EuiBasicTable

* pagination

* add sorting

* fix jest test

* handle out of order fetchs

* remove info.gif

* re-instate search functional test

* replace EuiSearchBar with EuiFieldSearch

* fix functional tests

* update snapshot - when code rebased - new EUI version add another prop

* add Edit link to actions column

nreese added a commit that referenced this pull request Apr 26, 2018

Eui dashboard listing (#16967) (#18605)
* convert dashboard listing page to react and EUI

* add jest test for DashboardListing component

* add data-test-subj attributes

* clean up jest test

* hideWriteControls and call to action when no dashboards exist

* pass initial filter to dashboard listing, get functional tests to work

* fix dashboard queries functional tests

* upgraded to EUI 0.0.29 to get defaultFocusedButton fix

* move dashboardListing directive to index

* spacing in if statement

* switch to EuiBasicTable

* pagination

* add sorting

* fix jest test

* handle out of order fetchs

* remove info.gif

* re-instate search functional test

* replace EuiSearchBar with EuiFieldSearch

* fix functional tests

* update snapshot - when code rebased - new EUI version add another prop

* add Edit link to actions column

@nreese nreese deleted the nreese:euiDashboardListing branch Jul 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.