Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] Rename TypeCollector to CollectorSet for semantics #18987

Conversation

Projects
None yet
3 participants
@tsullivan
Copy link
Contributor

commented May 10, 2018

Depends on #18939

This is the 2nd small PR to close #12504. I could tell it was a problem in the code that there's a typeCollector object that has a method for registering collector objects. This renames the TypeCollector class to CollectorSet which is a better representation of what it is.

Next will be classes for wrapping the collector objects which will provide metadata on how the collector is intended to be used. Any collector we have is going to be used for either operations / performance stats, or usage stats. When an object is passed to the register method, I want to add some validation that the object is an instance of a stats or usage class.

@elasticmachine

This comment has been minimized.

Copy link

commented May 10, 2018

@tsullivan tsullivan force-pushed the tsullivan:monitoring/type-collector-is-actually-a-set-of-collectors branch 2 times, most recently from 596d9dd to 2a5d567 May 10, 2018

@elasticmachine

This comment has been minimized.

Copy link

commented May 10, 2018

@tsullivan tsullivan force-pushed the tsullivan:monitoring/type-collector-is-actually-a-set-of-collectors branch from 2a5d567 to 9c95f71 May 15, 2018

@tsullivan tsullivan added review and removed WIP labels May 15, 2018

@tsullivan tsullivan requested a review from pickypg May 15, 2018

@elasticmachine

This comment has been minimized.

Copy link

commented May 15, 2018

@pickypg
Copy link
Member

left a comment

LGTM

@elasticmachine

This comment has been minimized.

Copy link

commented May 15, 2018

@tsullivan tsullivan merged commit 0940f57 into elastic:master May 15, 2018

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
kibana-ci Build finished.
Details

@tsullivan tsullivan deleted the tsullivan:monitoring/type-collector-is-actually-a-set-of-collectors branch May 15, 2018

tsullivan added a commit to tsullivan/kibana that referenced this pull request May 15, 2018

[Monitoring] Rename TypeCollector to CollectorSet for semantics (ela…
…stic#18987)

* [Monitoring] Rename TypeCollector to CollectorSet for semantics

* boring test changes

* usage collector renames

* rename initKibanaMonitoring => createCollectorSet

* fix lint

tsullivan added a commit that referenced this pull request May 16, 2018

[Monitoring] Rename TypeCollector to CollectorSet for semantics (#18987
) (#19088)

* [Monitoring] Rename TypeCollector to CollectorSet for semantics

* boring test changes

* usage collector renames

* rename initKibanaMonitoring => createCollectorSet

* fix lint

mistic added a commit to mistic/kibana that referenced this pull request May 16, 2018

[Monitoring] Rename TypeCollector to CollectorSet for semantics (ela…
…stic#18987)

* [Monitoring] Rename TypeCollector to CollectorSet for semantics

* boring test changes

* usage collector renames

* rename initKibanaMonitoring => createCollectorSet

* fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.