Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #18838 incorrect 403 message when generating reports #19054

Merged
merged 3 commits into from May 16, 2018

Conversation

Projects
None yet
4 participants
@chrisdavies
Copy link
Contributor

chrisdavies commented May 14, 2018

Fixes a reporting bug where Kibana incorrectly describes a 403 error as "Unable to reach the server".

@chrisdavies chrisdavies requested review from stacey-gammon and nreese May 14, 2018

@nreese

nreese approved these changes May 14, 2018

Copy link
Contributor

nreese left a comment

lgtm

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented May 14, 2018

return toastNotifications.addDanger({
title: 'Reporting error',
text: `You don't have permission to generate this report.`,
});

This comment has been minimized.

Copy link
@stacey-gammon

stacey-gammon May 15, 2018

Contributor

I think you'll have to add in 'data-test-subj': 'permissionReportError' and update the failing test so it now makes sure you get this error. Otherwise, LGTM!

@stacey-gammon
Copy link
Contributor

stacey-gammon left a comment

LGTM pending passing ci (looks like a test just needs to be updated)

@chrisdavies

This comment has been minimized.

Copy link
Contributor Author

chrisdavies commented May 16, 2018

Jenkins test this - I missed the window of opportunity to view the test failure...

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented May 16, 2018

@stacey-gammon

This comment has been minimized.

Copy link
Contributor

stacey-gammon commented May 16, 2018

Might need to rebase to get tests passing. nm, it's an error from the PR.

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented May 16, 2018

@chrisdavies chrisdavies merged commit 2f9185d into elastic:master May 16, 2018

2 checks passed

CLA Commit author has signed the CLA
Details
kibana-ci Build finished.
Details

@chrisdavies chrisdavies deleted the chrisdavies:bug/reporting-403-err-msg branch May 16, 2018

@stacey-gammon

This comment has been minimized.

Copy link
Contributor

stacey-gammon commented May 21, 2018

@chrisdavies - this is going into 7.0 and 6.4 right? not being backported to 6.3? Just a reminder to add version tags!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.