Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not break on startup in debug mode #19219

Merged

Conversation

Projects
None yet
5 participants
@thomasneirynck
Copy link
Contributor

commented May 18, 2018

starting up the server in debug mode should not interrupt by default.

@jbudz

jbudz approved these changes May 18, 2018

@bmcconaghy
Copy link
Contributor

left a comment

LGTM

@mistic

This comment has been minimized.

Copy link
Member

commented May 18, 2018

@thomasneirynck LGTM 👍

I just have a small thought on it: besides removing the --debug-brk from default behaviour why not also adding a new task like:

"debug-break": "node --nolazy --inspect-brk scripts/kibana --dev",

This way if anyone is using the debug break behaviour it will be able to still use it 😄

Note: I've replaced --debug-brk by --inspect-brk as the first one become deprecated since Node 7.7.0

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented May 18, 2018

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented May 18, 2018

@thomasneirynck thomasneirynck merged commit f3ea67e into elastic:master May 18, 2018

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
kibana-ci Build finished.
Details

@thomasneirynck thomasneirynck removed the v6.4.0 label May 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.