Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gaps in sample flight data #19912

Merged
merged 1 commit into from Jun 15, 2018

Conversation

Projects
None yet
4 participants
@nreese
Copy link
Contributor

nreese commented Jun 14, 2018

fixes #19665

There was a bug in the adjust timestamp logic. It was using getUTCDay values to calculate the dayOfWeekDelta. If the UTC wrapped to the next day then this caused problems.

Sample data now as no gaps. Data set inserted at 2018-06-14T14:00:00.000Z

screen shot 2018-06-14 at 10 52 55 am

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Jun 14, 2018

@nreese nreese requested review from chrisdavies and stacey-gammon Jun 14, 2018

@stacey-gammon
Copy link
Contributor

stacey-gammon left a comment

code changes lgtm. Did not pull down to check.

@chrisdavies
Copy link
Contributor

chrisdavies left a comment

LGTM

@nreese nreese merged commit bdebff9 into elastic:master Jun 15, 2018

2 checks passed

CLA Commit author has signed the CLA
Details
kibana-ci Build finished.
Details

nreese added a commit to nreese/kibana that referenced this pull request Jun 15, 2018

nreese added a commit that referenced this pull request Jun 16, 2018

maryia-lapata added a commit to maryia-lapata/kibana that referenced this pull request Jun 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.