Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[optimizer] allow prod optimizations when running source #20174

Merged
merged 1 commit into from Jun 22, 2018

Conversation

Projects
None yet
3 participants
@spalger
Copy link
Member

spalger commented Jun 22, 2018

In #19972 we switched from using env to determine when certain optimizer configuration should be in place to using the fact that we are running a distributable. Unfortunately the config needs to be more nuanced than that, so this PR refactors the config generation a bit to combine commonConfig with the transpileTsConfig, supportEnzymeConfig, and the productionConfig based on both the environment and wether we are running from source.

@tylersmalley
Copy link
Member

tylersmalley left a comment

LGTM

@spalger spalger merged commit 8fc0fca into elastic:master Jun 22, 2018

1 of 2 checks passed

kibana-ci Build started for merge commit.
Details
CLA Commit author has signed the CLA
Details

spalger added a commit to spalger/kibana that referenced this pull request Jun 22, 2018

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Jun 22, 2018

spalger added a commit that referenced this pull request Jun 23, 2018

[6.x] [optimizer] allow prod optimizations when running source (#20174)…
… (#20175)

Backports the following commits to 6.x:
 - [optimizer] allow prod optimizations when running source  (#20174)
@spalger

This comment has been minimized.

Copy link
Member Author

spalger commented Jun 23, 2018

6.x/6.4: 229e336

@spalger spalger deleted the spalger:fix/optimizer/prod-from-source branch Jun 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.