Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create nested search source per postflightrequest #20373

Merged
merged 1 commit into from Jul 3, 2018

Conversation

Projects
None yet
4 participants
@timroes
Copy link
Contributor

commented Jul 2, 2018

Fix #16928

Instead of creating a new child search source for every postflightrequest, let the postflightrequest decide itself if it needs/wants that, and instead pass in the searchsource that was used to execute the actual request.

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Jul 2, 2018

@cjcenizal
Copy link
Contributor

left a comment

Code LGTM!

@markov00
Copy link
Member

left a comment

Code LGTM.

@timroes timroes merged commit 59426cb into elastic:master Jul 3, 2018

2 checks passed

CLA Commit author has signed the CLA
Details
kibana-ci Build finished.
Details

@timroes timroes deleted the timroes:refactor-postflightreq branch Jul 3, 2018

timroes added a commit to timroes/kibana that referenced this pull request Jul 3, 2018

timroes added a commit that referenced this pull request Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.