Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor courier by naming internal searchRequest variable consistently. #20448

Merged
merged 2 commits into from Jul 5, 2018

Conversation

Projects
None yet
3 participants
@cjcenizal
Copy link
Contributor

cjcenizal commented Jul 4, 2018

No functional changes.

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Jul 4, 2018

@bmcconaghy
Copy link
Contributor

bmcconaghy left a comment

LGTM, just had a minor comment.

return ABORTED;
}

const resp = responses[i];
const resp = responses[index];

This comment has been minimized.

Copy link
@bmcconaghy

bmcconaghy Jul 5, 2018

Contributor

Should resp be response here to be consistent? Looks like response is used elsewhere.

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Jul 5, 2018

@cjcenizal cjcenizal merged commit ddb890c into elastic:master Jul 5, 2018

2 checks passed

CLA Commit author has signed the CLA
Details
kibana-ci Build finished.
Details

@cjcenizal cjcenizal deleted the cjcenizal:refactor-fetch-now branch Jul 5, 2018

cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Jul 5, 2018

cjcenizal added a commit that referenced this pull request Jul 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.