Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relative url for visualizations with terms aggregations #20521

Merged
merged 1 commit into from Jul 9, 2018

Conversation

Projects
None yet
4 participants
@chrisronline
Copy link
Contributor

commented Jul 6, 2018

Fixes elastic/apm-server#1059
Related to #14994

We're having to manually pass in url information to the url field formatter because it runs on the server too and can't assume ui/chrome exists. We missed a spot where this is needed to make visualizations with term aggs work properly.

@elasticmachine

This comment has been minimized.

Copy link

commented Jul 6, 2018

@jen-huang
Copy link
Contributor

left a comment

Tested a visualization with URL formatted field with and without fix. Fix works great!

LGTM

@bmcconaghy
Copy link
Contributor

left a comment

Code LGTM

@chrisronline chrisronline merged commit 6ef5d8d into elastic:master Jul 9, 2018

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
kibana-ci Build finished.
Details

@chrisronline chrisronline deleted the chrisronline:fix/apm/1059 branch Jul 9, 2018

chrisronline added a commit to chrisronline/kibana that referenced this pull request Jul 9, 2018

@chrisronline chrisronline removed the v6.3.2 label Jul 9, 2018

chrisronline added a commit to chrisronline/kibana that referenced this pull request Jul 9, 2018

chrisronline added a commit that referenced this pull request Jul 9, 2018

@chrisronline

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2018

Backport:

6.x: 3b3dc0b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.