Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make aggTypeFilter registry return value directly #20523

Merged
merged 1 commit into from Jul 6, 2018

Conversation

Projects
None yet
4 participants
@timroes
Copy link
Contributor

timroes commented Jul 6, 2018

After some thoughts and discussion around UX and our loading infrastructure, I decided to make the aggTypeFilters registry return a value instead of an observable, i.e. you won't be notified if any new filter is registered.

The reason is, that all filters should be registered during startup and there should never be the use-case to add filters on the fly while the editor is already used. With using app extension points that already works like that, and it will also work pretty much the same with the lifecycle of the new platform.

@jen-huang
Copy link
Contributor

jen-huang left a comment

Makes sense. LGTM!

@cjcenizal
Copy link
Contributor

cjcenizal left a comment

⭐️ LGTM!

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Jul 6, 2018

@timroes timroes merged commit 3c3d18c into elastic:master Jul 6, 2018

2 checks passed

CLA Commit author has signed the CLA
Details
kibana-ci Build finished.
Details

@timroes timroes deleted the timroes:static-registry branch Jul 6, 2018

timroes added a commit to timroes/kibana that referenced this pull request Jul 6, 2018

timroes added a commit that referenced this pull request Jul 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.