Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[config] transform plugin deprecations before checking for unused settings #21294
Currently the server throws a fatal error if a setting in kibana.yml is specified that isn'tused in the application.
This check works by comparing the list of raw settings in kibana.yml with the list of validated settings, and if there are any discrepancies we know there's an extraneous setting. Prior to doing the comparison we transform any deprecated settings into their expected format. This transformation is only performed on core kibana settings, causing any deprecated setting in a plugin to not be transformed and resulting in an error. This PR goes through the list of plugins and performs any transforms necessary.
spalger left a comment
These changes look good, but there is another place we are doing this same thing:
referenced this pull request
Oct 18, 2018
Looks like the exception is still bubling up.