Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fix for wizard card layout when cloning #21403

Merged
merged 1 commit into from Jul 30, 2018

Conversation

Projects
None yet
4 participants
@jgowdyelastic
Copy link
Member

commented Jul 30, 2018

Rather than using jquery to measure the front card and then calculate the widths and margins of the cards behind, this PR hard codes the values in 10 css rules.
Also moves the card's css rules to a common location as they are identical for multi-metric and population wizards.

Fixes #21401

@elasticmachine

This comment has been minimized.

Copy link

commented Jul 30, 2018

Pinging @elastic/ml-ui

@peteharverson
Copy link
Contributor

left a comment

LGTM

@walterra
Copy link
Contributor

left a comment

LGTM

@elasticmachine

This comment has been minimized.

Copy link

commented Jul 30, 2018

@jgowdyelastic jgowdyelastic merged commit 943681b into elastic:master Jul 30, 2018

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
kibana-ci Build finished.
Details

jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Jul 30, 2018

jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Jul 30, 2018

jgowdyelastic added a commit that referenced this pull request Jul 30, 2018

jgowdyelastic added a commit that referenced this pull request Jul 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.