Fix default messages extractor bug with line break escaping #22140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeanidShutau
added
bug
yankouskia
approved these changes
Aug 17, 2018
src/dev/i18n/utils.test.js
Outdated
| expect( | ||
| formatJSString(`Test | ||
| multiline | ||
| string`) |
There was a problem hiding this comment.
let's please add test with something like:
`text with 2
line-breaks and 2 \n\n
\n\n
for example
`?
(and maybe toMatchSnapshot will be easier?)
💚 Build Succeeded |
LeanidShutau
added a commit
to LeanidShutau/kibana
that referenced
this pull request
Aug 21, 2018
…22140) * Fix default messages extractor bug with line break escaping * Change test case
LeanidShutau
added a commit
that referenced
this pull request
Aug 21, 2018
|
6.x/6.5: 75a1769 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug:
en.jsongenerated by default messages extraction tool contains not escaped line breaks ifdefaultMessagecontains more then one line break.Reason:
String.replace(string, string)is not recursive.String.replace(RegExp, string)should be used instead.How to test:
Jest test with described case has been added to
utils.test.js.