Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming Monitoring FormattedMessage to FormattedAlert #24197

Conversation

Projects
None yet
4 participants
@salexa92
Copy link
Contributor

commented Oct 18, 2018

This change fixes #23641.
Renamed monitoring FormattedMessage to FormattedAlert and update the files using this component with the new name and import.

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Oct 18, 2018

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@salexa92 salexa92 changed the title Fixes #23641 Renaming Monitoring FormattedMessage to FormattedAlert Oct 18, 2018

@maryia-lapata

This comment has been minimized.

Copy link
Contributor

commented Oct 25, 2018

@salexa92 When are these changes planned to be merged? Localization team has already started working on translation for Monitoring and #23641 is blocking us.

/cc @pickypg, @chrisronline, @azasypkin, @pavel06081991

@chrisronline chrisronline self-assigned this Oct 25, 2018

@chrisronline

This comment has been minimized.

Copy link
Contributor

commented Oct 25, 2018

jenkins, test this

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Oct 25, 2018

@chrisronline
Copy link
Contributor

left a comment

LGTM!

@chrisronline chrisronline merged commit ab776d4 into elastic:master Oct 25, 2018

2 checks passed

CLA Commit author has signed the CLA
Details
kibana-ci Build finished.
Details
@chrisronline

This comment has been minimized.

Copy link
Contributor

commented Oct 25, 2018

Will wait to backport until 6.5 is cut from 6.x

chrisronline added a commit to chrisronline/kibana that referenced this pull request Oct 25, 2018

chrisronline added a commit that referenced this pull request Oct 29, 2018

@chrisronline

This comment has been minimized.

Copy link
Contributor

commented Oct 29, 2018

Backport:
6.x: c3be77b

joelgriffith added a commit to joelgriffith/kibana that referenced this pull request Nov 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.