New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: get correct plugins path #25448

Merged
merged 1 commit into from Nov 9, 2018

Conversation

Projects
None yet
3 participants
@w33ble
Member

w33ble commented Nov 9, 2018

Closes #25447

We can't check the name of the outer path because it can change.

This PR changes the check, so we just make sure there's a plugins path where we expect to find one.

fix: get correct plugins path
we can't check the name of the outer path because it can change, instead, just make sure there's a plugins path there
@elasticmachine

This comment has been minimized.

elasticmachine commented Nov 9, 2018

@w33ble w33ble requested a review from rashidkpc Nov 9, 2018

@rashidkpc

This comment has been minimized.

Member

rashidkpc commented Nov 9, 2018

Built this, tested it, LGTM

@w33ble w33ble merged commit 830c195 into elastic:master Nov 9, 2018

1 of 2 checks passed

kibana-ci Build started for merge commit.
Details
CLA Commit author has signed the CLA
Details

w33ble added a commit that referenced this pull request Nov 9, 2018

fix: get correct plugins path (#25448)
we can't check the name of the outer path because it can change, instead, just make sure there's a plugins path there

w33ble added a commit that referenced this pull request Nov 9, 2018

fix: get correct plugins path (#25448)
we can't check the name of the outer path because it can change, instead, just make sure there's a plugins path there
@w33ble

This comment has been minimized.

Member

w33ble commented Nov 9, 2018

6.5 467f35f
6.x 177dde9

@elasticmachine

This comment has been minimized.

elasticmachine commented Nov 9, 2018

@w33ble w33ble added v6.5.1 and removed v6.5.0 labels Nov 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment