New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move optimize into data folder #25944

Open
wants to merge 14 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@jbudz
Copy link
Contributor

jbudz commented Nov 20, 2018

We have a general purpose data folder used for application writes, and there's some overlap with this and the optimize folder. We want all writes to go to the same folder so we can set this path to /var/lib/kibana for deb/rpm packages.

https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch05s08.html

This hierarchy holds state information pertaining to an application or the system. State information is data that programs modify while they run, and that pertains to one specific host. Users must never need to modify files in /var/lib to configure a package's operation, and the specific file hierarchy used to store the data must not be exposed to regular users.

Currently in the data folder we'll extract phantomjs, create a uuid, and store the keystore. This moves bundles and bundle caches there in addition

Closes #15899
Closes #5071

jbudz added some commits Nov 20, 2018

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Nov 20, 2018

@tylersmalley

This comment has been minimized.

Copy link
Member

tylersmalley commented Nov 20, 2018

Do we have any public documentation mentioning the previous location?

@mistic

This comment has been minimized.

Copy link
Member

mistic commented Nov 20, 2018

@jbudz I have to little questions. Should we also update src/dev/notice/generate_notice_from_source.js ? I like that idea as it will help us to prevent unintended deletion of that folder, but shouldn't we create a way to let users know that we move that folder?

jbudz added some commits Nov 20, 2018

@elasticmachine

This comment was marked as resolved.

Copy link

elasticmachine commented Nov 20, 2018

@elasticmachine

This comment was marked as resolved.

Copy link

elasticmachine commented Nov 20, 2018

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Nov 20, 2018

@mistic

mistic approved these changes Nov 20, 2018

Copy link
Member

mistic left a comment

LGTM

@@ -125,12 +125,6 @@ important data later on.
| $KIBANA_HOME\data
d|

| optimize

This comment has been minimized.

@epixa

epixa Nov 21, 2018

Member

Given that "delete the contents of the optimize directory" is pretty common advice, we should probably keep its location explicitly documented, even if it's $KIBANA_HOME\data\optimize

jbudz added some commits Jan 24, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Jan 24, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Jan 25, 2019

jbudz added some commits Feb 5, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 5, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 5, 2019

@tylersmalley

This comment has been minimized.

Copy link
Member

tylersmalley commented Feb 7, 2019

nit: can remove /optimize from .eslintignore

jbudz added some commits Feb 7, 2019

@tylersmalley
Copy link
Member

tylersmalley left a comment

LGTM and tested through builds.

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 7, 2019

@tylersmalley

This comment has been minimized.

Copy link
Member

tylersmalley commented Feb 13, 2019

It's too late to get this into 7. Mind updating the docs to put this into breaking changes for 8?

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment