Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mutex from kbn pm bootstrap as all ci jobs are running isolated #26058

Merged
merged 1 commit into from Nov 22, 2018

Conversation

mistic
Copy link
Member

@mistic mistic commented Nov 22, 2018

This is a small PR as an effort to solve the problems we are having recurrently like:

00:00:12 /var/lib/jenkins/.kibana/node/8.11.4/lib/node_modules/yarn/lib/cli.js:77868
00:00:12     compromised = compromised || function (err) { throw err; };
00:00:12                                                   ^
00:00:12 
00:00:12 Error: Unable to update lock within the stale threshold
00:00:12     at options.fs.utimes (/var/lib/jenkins/.kibana/node/8.11.4/lib/node_modules/yarn/lib/cli.js:77790:66)
00:00:12     at FSReqWrap.oncomplete (fs.js:135:15)
00:00:13 
00:00:13 [bootstrap] failed:

@mistic mistic requested a review from spalger November 22, 2018 01:21
@mistic mistic added review Team:Operations Team label for Operations Team v7.0.0 labels Nov 22, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@mistic mistic added the v6.6.0 label Nov 22, 2018
@mistic mistic self-assigned this Nov 22, 2018
@joshdover
Copy link
Member

Do we know exactly why this was added in the first place?

@mistic
Copy link
Member Author

mistic commented Nov 22, 2018

@joshdover according to @spalger there was a time when it was needed, but right now all the CI jobs are isolated in different vms, so I think it's secure to remove it!

@joshdover
Copy link
Member

joshdover commented Nov 22, 2018 via email

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mistic
Copy link
Member Author

mistic commented Nov 22, 2018

6.x: 1d662e5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Team:Operations Team label for Operations Team v6.6.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants