New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mutex from kbn pm bootstrap as all ci jobs are running isolated #26058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/kibana-operations |
Do we know exactly why this was added in the first place? |
@joshdover according to @spalger there was a time when it was needed, but right now all the CI jobs are isolated in different vms, so I think it's secure to remove it! |
Great!
On Nov 21, 2018 7:25 PM, "Tiago Costa" <notifications@github.com> wrote:
@joshdover <https://github.com/joshdover> according to @spalger
<https://github.com/spalger> there was a time when it was needed, but right
now all the CI jobs are isolated in different vms, so I think it's secure
to remove it!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#26058 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABuqENDwMyE2eSOOzHJ5prvrXJFm5LCwks5uxfz0gaJpZM4YugmJ>
.
|
joshdover
approved these changes
Nov 22, 2018
💚 Build Succeeded |
spalger
approved these changes
Nov 22, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Nov 22, 2018
mistic
added a commit
that referenced
this pull request
Nov 22, 2018
6.x: 1d662e5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small PR as an effort to solve the problems we are having recurrently like: