Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrolling list on Firefox #26246

Merged
merged 2 commits into from Dec 3, 2018

Conversation

@markov00
Copy link
Member

commented Nov 27, 2018

Summary

Fix #26209

The issue is related to the requirement of having min-height: 0 on the content wrapper div es explained https://moduscreate.com/blog/how-to-fix-overflow-issues-in-css-flex-layouts/ or https://bugzilla.mozilla.org/show_bug.cgi?id=1176723

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@markov00 markov00 self-assigned this Nov 27, 2018

@markov00 markov00 requested a review from timroes Nov 27, 2018

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Nov 27, 2018

@markov00

This comment has been minimized.

Copy link
Member Author

commented Nov 27, 2018

Legit failure. Missing updating test snapshots.

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Nov 27, 2018

@timroes
Copy link
Contributor

left a comment

Code looks as good as it can while dealing with CSS issues to me :-) Tested in Firefox, fixed the behavior.

@markov00 markov00 force-pushed the markov00:fix/new_viz_modal_scroll_ff branch from 4c98baa to 98d7727 Dec 3, 2018

markov00 added 2 commits Nov 27, 2018

@markov00 markov00 force-pushed the markov00:fix/new_viz_modal_scroll_ff branch from 98d7727 to f4ba812 Dec 3, 2018

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Dec 3, 2018

@markov00 markov00 merged commit 97f0dcb into elastic:master Dec 3, 2018

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
kibana-ci Build finished.
Details
markov00 added a commit to markov00/kibana that referenced this pull request Dec 3, 2018
Fix scrolling list on Firefox (elastic#26246)
* Fix scrolling list on Firefox

* Update jest snapshost after adding a class to modal
markov00 added a commit to markov00/kibana that referenced this pull request Dec 3, 2018
Fix scrolling list on Firefox (elastic#26246)
* Fix scrolling list on Firefox

* Update jest snapshost after adding a class to modal
markov00 added a commit to markov00/kibana that referenced this pull request Dec 3, 2018
Fix scrolling list on Firefox (elastic#26246)
* Fix scrolling list on Firefox

* Update jest snapshost after adding a class to modal
markov00 added a commit that referenced this pull request Dec 3, 2018
Fix scrolling list on Firefox (#26246) (#26532)
* Fix scrolling list on Firefox

* Update jest snapshost after adding a class to modal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.