Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrolling list on Firefox #26246

Merged
merged 2 commits into from Dec 3, 2018
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Next

Fix scrolling list on Firefox

  • Loading branch information...
markov00 committed Nov 27, 2018
commit 2c0f46de671a0ab2f211cd0ebab09336983d3278
@@ -8,6 +8,10 @@
.visNewVisDialog__body {
display: flex;
padding: $euiSizeM $euiSizeL 0;
min-height: 0;
}
.visNewVisDialog__list {
min-height: 0;
}

.visNewVisDialog__searchWrapper {
@@ -16,6 +20,7 @@

.visNewVisDialog__typesWrapper {
max-width: $euiSizeXXL * 10;
min-height: 0;
padding-top: 2px; // Account for search field dropshadow
padding-bottom: $euiSize;
// Add overflow shadows via pseudo elements
@@ -79,7 +79,12 @@ class TypeSelection extends React.Component<TypeSelectionProps, TypeSelectionSta
<div className="visNewVisDialog__body">
<EuiFlexGroup gutterSize="xl">
<EuiFlexItem>
<EuiFlexGroup direction="column" gutterSize="none" responsive={false}>
<EuiFlexGroup
className="visNewVisDialog__list"
direction="column"
gutterSize="none"
responsive={false}
>
<EuiFlexItem grow={false} className="visNewVisDialog__searchWrapper">
<EuiFieldSearch
placeholder="Filter"
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.