Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite URL when closing vis type selection modal #26327

Merged
merged 1 commit into from Nov 29, 2018

Conversation

Projects
None yet
3 participants
@timroes
Copy link
Contributor

commented Nov 28, 2018

Summary

Fixes #26230

The empty state no longer will redirect to the /visualize/new URL, but instead load the new vis modal in place.

Also when you navigate to the URL, and close the dialog, the URL will now change to /visualize. This will actually refresh the route. Since the URL is scheduled for removal, I think it's not worth messing with the window history at this place (and thus need to build URLs manually), but we can just rely on kbnUrl service instead.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Nov 28, 2018

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Nov 28, 2018

@cjcenizal
Copy link
Contributor

left a comment

LGTM! Tested locally, code review.

@timroes timroes merged commit 64e26c4 into elastic:master Nov 29, 2018

2 checks passed

CLA Commit author has signed the CLA
Details
kibana-ci Build finished.
Details

@timroes timroes deleted the timroes:fix-new-vis-editor-url branch Nov 29, 2018

timroes added a commit to timroes/kibana that referenced this pull request Nov 29, 2018

timroes added a commit that referenced this pull request Nov 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.