Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SavedObjectClient types alongside js source #26448

Conversation

@weltenwort
Copy link
Contributor

commented Nov 29, 2018

This moves the types for the server-side SavedObjectsClient from the spaces plugin to the same location as the corresponding JavaScript source files. Consequently, these types can be re-used by other plugins as well.

While imports of runtime code across plugin boundaries is not supported in Kibana, importing type definitions is not subject to that limitation as long as it does not emit any JavaScript code during compilation.

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Nov 29, 2018

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Nov 30, 2018

@weltenwort weltenwort force-pushed the weltenwort:refactor-colocate-saved-object-client-types branch from 6586e08 to 099ac36 Dec 3, 2018

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Dec 3, 2018

💚 Build Succeeded

@legrego
legrego approved these changes Dec 3, 2018
Copy link
Contributor

left a comment

LGTM - code review. Thanks for this!

@weltenwort weltenwort merged commit bd34942 into elastic:master Dec 3, 2018

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
kibana-ci Build finished.
Details
weltenwort added a commit to weltenwort/kibana that referenced this pull request Dec 3, 2018
weltenwort added a commit that referenced this pull request Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.