New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows SIGHUP to recreate log file handler #26675

Merged
merged 6 commits into from Dec 5, 2018

Conversation

Projects
None yet
7 participants
@tylersmalley
Member

tylersmalley commented Dec 5, 2018

Closes #26673

Another solution being discussed is outlined in 693b3ab

@azasypkin, feel free to push changes or close this issue in favor of something else.

spalger and others added some commits Dec 5, 2018

Adds test for recreating file handler on SIGHUP
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@elasticmachine

This comment has been minimized.

elasticmachine commented Dec 5, 2018

@spalger

This comment has been minimized.

Member

spalger commented Dec 5, 2018

@elasticmachine

This comment has been minimized.

elasticmachine commented Dec 5, 2018

Remove unused imports
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@elasticmachine

This comment was marked as outdated.

elasticmachine commented Dec 5, 2018

@elasticmachine

This comment was marked as outdated.

elasticmachine commented Dec 5, 2018

@azasypkin

This comment has been minimized.

Member

azasypkin commented Dec 5, 2018

retest

@mistic

mistic approved these changes Dec 5, 2018

LGTM

[Tests] Use proper value for the `second`, clear timeout on match, ca…
…ll `done` on timeout with error message.
@elasticmachine

This comment was marked as outdated.

elasticmachine commented Dec 5, 2018

@elasticmachine

This comment has been minimized.

elasticmachine commented Dec 5, 2018

@azasypkin azasypkin merged commit 5de54bb into elastic:master Dec 5, 2018

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
kibana-ci Build finished.
Details

@azasypkin azasypkin added the blocker label Dec 5, 2018

azasypkin added a commit to azasypkin/kibana that referenced this pull request Dec 5, 2018

Allows SIGHUP to recreate log file handler (elastic#26675)
Co-authored-by: spalger <email@spalger.com>
Co-authored-by: Tyler Smalley <tyler.smalley@elastic.co>

azasypkin added a commit to azasypkin/kibana that referenced this pull request Dec 5, 2018

Allows SIGHUP to recreate log file handler (elastic#26675)
Co-authored-by: spalger <email@spalger.com>
Co-authored-by: Tyler Smalley <tyler.smalley@elastic.co>
@azasypkin

This comment has been minimized.

Member

azasypkin commented Dec 5, 2018

6.5/6.5.3: 069130e
6.x/6.6: 9dd606b

@epixa

This comment has been minimized.

Member

epixa commented Dec 5, 2018

@azasypkin if the 6.5 backport applied cleanly, I think it's safe to use the success of 6.x CI in the meantime. We haven't made substantial changes to config stuff in between 6.x and 6.5.

@azasypkin

This comment has been minimized.

Member

azasypkin commented Dec 5, 2018

@azasypkin if the 6.5 backport applied cleanly, I think it's safe to use the success of 6.x CI in the meantime.

Yeah, I only had a bunch of conflicts in reload_logging_config.test.js, but there were exactly same conflicts I had in 6.x (due to missing backport of #26205).

@thomasneirynck

This comment has been minimized.

Contributor

thomasneirynck commented Dec 5, 2018

we haven't started building BC1 for 6.5.3 yet either, so fine to merge imho

@azasypkin

This comment has been minimized.

Member

azasypkin commented Dec 5, 2018

Done, I'll be monitoring 6.5 CI once ES snapshot is available to confirm that we don't have any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment