Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra UI] Change node detail link to set time range to 1 hour #26977

Merged
merged 5 commits into from Dec 13, 2018

Conversation

@simianhacker
Copy link
Member

commented Dec 11, 2018

This PR changes the link from the waffle map to the node detail page so that the time range is set to an hour instead of the 5 minutes (used for the waffle map).

Reviewers: First come first serve, we just need one.

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Dec 11, 2018

Pinging @elastic/infrastructure-ui

@simianhacker simianhacker requested review from weltenwort, skh and Kerry350 Dec 11, 2018

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Dec 11, 2018

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Dec 12, 2018

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Dec 12, 2018

@skh
skh approved these changes Dec 12, 2018
Copy link
Contributor

left a comment

@simianhacker Thanks for the change!

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Dec 12, 2018

@simianhacker simianhacker merged commit ff20e3e into elastic:master Dec 13, 2018

2 checks passed

CLA Commit author has signed the CLA
Details
kibana-ci Build finished.
Details

@zube zube bot added [zube]: Done and removed [zube]: In Review labels Dec 13, 2018

simianhacker added a commit to simianhacker/kibana that referenced this pull request Dec 13, 2018
[Infra UI] Change node detail link to set time range to 1 hour (elast…
…ic#26977)

* Change time range for link to -1h

* Moving timeRange manipulation up a level to the node component
simianhacker added a commit that referenced this pull request Dec 13, 2018
[Infra UI] Change node detail link to set time range to 1 hour (#26977)…
… (#27134)

* Change time range for link to -1h

* Moving timeRange manipulation up a level to the node component
WangQianliang added a commit to WangQianliang/kibana that referenced this pull request Dec 18, 2018
[Infra UI] Change node detail link to set time range to 1 hour (elast…
…ic#26977)

* Change time range for link to -1h

* Moving timeRange manipulation up a level to the node component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.